linux-kernel mailing list

FromSubjectsort iconDate
lkml777
Re: Question about Reiser4 (how to boot it?)
Thanks, that is certainly helpful, but that only mounts one directory (partition) as Reiser4. This I have already done. I was more interested in how to have a whole partition dedicated to Reiser4 and being able to boot into it. By any chance did you do that? On Sat, 28 Apr 2007 00:37:05 +0800, "Jeff Chua" -- lkml777@123mail.org -- http://www.fastmail.fm - And now for something completely different… -
Apr 27, 7:38 pm 2007
Robert Hancock
Re: More than 2Gb problem (dvb related) ?
Sounds like the cx88 driver is not using the DMA API properly to set up proper mappings, this will blow up if it tries to access memory above the 4GB mark if the device cannot do >32bit DMA.. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -
Apr 27, 6:55 pm 2007
Markus Rechberger
Re: More than 2Gb problem (dvb related) ?
Does this only happen with DVB and not with analogue TV (I know there are some cx88 hybrid devices out there, I recently got one but couldn't tested it yet ..)? Markus -- Markus Rechberger -
Apr 27, 7:24 pm 2007
Greg KH Apr 27, 6:49 pm 2007
Andrew Morton
Re: [GIT PATCH] UIO patches for 2.6.21
On Fri, 27 Apr 2007 15:49:57 -0700 I'm a bit uncertain about the whole UIO idea, really. I have this vague feeling that we'd prefer to encourage people to move device drivers into GPL'ed kernel rather than encouraging them to do closed-source userspace implementations which will probably end up being slower, less reliable and unavailable on various architectures, distros, etc. But I don't think I have the capacity to actually think about this further eh? How come a particular device requires ...
Apr 27, 7:04 pm 2007
Alan Cox
Re: [GIT PATCH] UIO patches for 2.6.21
UIO is suprisingly close to chunks of the drm driver so the basic design seems to have some sanity to it. Alan -
Apr 27, 7:26 pm 2007
Greg KH
Re: [GIT PATCH] UIO patches for 2.6.21
It's not a closed vs. open issue, it just turns out that a lot of people keep trying to write PCI drivers in userspace (how many different papers were published on this topic alone in the past year...). This framework is to allow this to happen in a sane and correct way. Lots of different types of odd devices do not fit into the "kernelspace driver" framework very well for a variety of reasons: - zillions of different controls in the card - floating point is needed to compute the next step of ...
Apr 27, 7:11 pm 2007
Greg Kroah-Hartman
[PATCH 1/3] UIO: Add the User IO core code
From: Hans J. Koch <hjk@linutronix.de> This interface allows the ability to write the majority of a driver in userspace with only a very small shell of a driver in the kernel itself. It uses a char device and sysfs to interact with a userspace process to process interrupts and control memory accesses. See the docbook documentation for more details on how to use this interface. From: Hans J. Koch <hjk@linutronix.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Benedikt Sprang...
Apr 27, 6:50 pm 2007
Alan Cox
Flaws with "UIO: Add the User IO core code"
AFAIK we don't currently have any platform that runs binaries with different sizes of "int" but this is a) an unsigned value anyway, and b) should be a fixed type (eg u32) Otherwise it looks ok at the momenmt, although there is a real nasty waiting for anyone who tries to use it. At the point open is possible or IRQs can be enabled you are safe in the core merged as idev->info is always valid, but any driver module trying to go back via info->uio_dev has a NULL pointer for an early IRQ or o...
Apr 27, 7:19 pm 2007
Greg Kroah-Hartman
[PATCH 2/3] UIO: Documentation
From: Hans J. Koch <hjk@linutronix.de> Documentation for the UIO interface From: Hans J. Koch <hjk@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/DocBook/kernel-api.tmpl | 4 + Documentation/DocBook/uio-howto.tmpl | 498 +++++++++++++++++++++++++++++++++ 2 files changed, 502 insertions(+), 0 deletions(-) create mode 100644 Documentation/DocBook/uio-howto.tmpl diff --git a/Documentation/DocBook/kernel-api.tmpl b/Documentation/DocBoo...
Apr 27, 6:50 pm 2007
Greg Kroah-Hartman Apr 27, 6:50 pm 2007
Michal Piotrowski
2.6.21-rc7: known regressions
Hi all, Here is a list of known regressions reported after 2.6.21 release. Feel free to add new regressions/remove fixed etc. http://lkr.wikidot.com/list Subject : 2.6.21 don't boot, it stops after ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 *5 6 7 9 10 11 12 14 15). References : http://lkml.org/lkml/2007/4/27/400 Submitter : Riccardo Ricci <rricci@nuovanetmore.it> Status : unknown Subject : ACPI interpreter errors References : http://lkml.org/lkml/2007/4/27/206 Submitter : Udo A. Ste...
Apr 27, 6:38 pm 2007
Domenico Andreoli
Re: 2.6.21-rc7: known regressions
if this was also on a wiki page... 1) contributors (also casual ones) may update it or add new entries 2) adding a "Forwarded-To:" field and a "renew" button, regression reports could be fired semi-automatically to the right recipients. also the casual reader might bug proper maintainer simply clicking on the button. grave regressions would get more clicks... 3) when the new release is cut, such page is converted and saved as known regression list 4) a mail filter on lkml could perfo...
Apr 27, 7:58 pm 2007
Greg KH
Linux 2.6.21.1
We (the -stable team) are announcing the release of the 2.6.21.1 kernel. This release has two bugfixes for networking issues that should cause all users of ipv4 or ipv6 to upgrade to this version. I'll also be replying to this message with a copy of the patch between 2.6.21 and 2.6.21.1 The updated 2.6.21.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.21.y.git and can be browsed at the normal kernel.org git web browser: [ message continues ]
" title="www.kernel.org/g...">www.kernel.org/g...
Apr 27, 6:02 pm 2007
Greg KH
Re: Linux 2.6.21.1
diff --git a/Makefile b/Makefile index d970cb1..58c08d1 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 21 -EXTRAVERSION = +EXTRAVERSION = .1 NAME = Nocturnal Monster Puppy # *DOCUMENTATION* diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index cac06c4..444a56b 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -777,6 +777,10 @@ static void nl_fib_lookup(struct fib_result_nl *frn, struct fib_table *tb ) ...
Apr 27, 6:02 pm 2007
Greg KH
Linux 2.6.20.10
We (the -stable team) are announcing the release of the 2.6.20.10 kernel. This release has two bugfixes that fix the fixes that were in 2.6.20.8 and 2.6.20.9. We are sorry for the constant stream of releases, but these are security issues and as such, sometimes it is better to err on the side of quicker updates rather than an expanded window of vulnerability. Many thanks go out to the networking kernel developers who resolved these issues faster than seemed imaginable. Anyone who uses ipv4 or i...
Apr 27, 5:55 pm 2007
Greg KH
Re: Linux 2.6.20.10
diff --git a/Makefile b/Makefile index 3e7e6c7..b9ba823 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 20 -EXTRAVERSION = .9 +EXTRAVERSION = .10 NAME = Homicidal Dwarf Hamster # *DOCUMENTATION* diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index fa2cb8c..30aae76 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -773,6 +773,10 @@ static void nl_fib_lookup(struct fib_result_nl *frn, struct fib_table *tb ) ...
Apr 27, 5:56 pm 2007
Art Haas
Re: [patch] CFS scheduler, -v6
Hi. Just wanted to chime and and say that my build of 2.6.21 + CFS-v6 + PI patch by Thomas Gleixner has been running exceptionally well on my single processor PII machine (Debian unstable) and my SMP PII machine (Fedora Rawhide). On both systems no automatic 'renice'-ing happens, and I've not noticed any performance issues on the Debian box while in X. The Fedora machine currently runs X only occasionally as most of the time I use it for building and testing various non-graphical things. Art Ha...
Apr 27, 5:59 pm 2007
Bob Tracy
BAD_SG_DMA panic in aha1542
I previously reported an ISA DMA issue for the 2.6.12 kernel. The issue persists through at least 2.6.18. SCSI controller is an Adaptec AHA-1542B (ISA). The action "mount -t iso9660 /dev/scd0 /mnt/cdrom -r" produces (cdrom detection messages as various modules autoload, then...) sgpnt[0:1] page c1ee5af0/0x1ee5af0 length 32 Kernel panic - not syncing: Buffer at physical address > 16 Mb used for aha1542 As before, no problems using the sda hard disk (which is the boot drive): everything ...
Apr 27, 5:47 pm 2007
James Bottomley
Re: BAD_SG_DMA panic in aha1542
Knowing what these messages are is would be helpful; it tells me what I'm interested. This is clearly a use_sg==1 path that has failed to bounce the buffer for some reason ... and I was contemplating eliminating the GFP_DMA from our sr driver because I thought the block bouncing had it covered. It might also be helpful to apply this patch. It should give a stack trace of the problem command and not immediately panic the box. Thanks, James diff --git a/drivers/scsi/aha1542.c b/drivers...
Apr 27, 6:21 pm 2007
Bob Tracy
Re: BAD_SG_DMA panic in aha1542
Sorry about that... I'm running the DSL-N distribution (based on Knoppix), and having to transcribe the log messages by hand from the console, i.e., there's no logfile to cut-and-paste from :-(. I don't have access to the machine except on weekdays, but I'll repeat the I'll throw together a 2.6.21 kernel with this patch and give it a try. Again, it will be at least Monday before you hear back from me on this. Thanks! -- ---------------------------------------------------------------------...
Apr 27, 7:53 pm 2007
Alan Cox
Re: BAD_SG_DMA panic in aha1542
A little quiet contemplation and gnome number 387 suggests trying the following (and providing more detailed information such as the last message printed before the DMA message). Stuff a BUG() before the panic in BAD_DMA (aha1542.c) if needed to get a good trace. Please report success/failure/change. --- drivers/scsi/sr_ioctl.c~ 2007-04-27 22:53:33.885035256 +0100 +++ drivers/scsi/sr_ioctl.c 2007-04-27 22:53:33.885035256 +0100 @@ -187,9 +187,10 @@ struct scsi_sense_hdr sshdr; int result, ...
Apr 27, 6:13 pm 2007
Bob Tracy
Re: BAD_SG_DMA panic in aha1542
Can do. I don't have access to the machine on weekends, so it will be at least Monday before I can give this a whirl. Thanks! -- ----------------------------------------------------------------------- Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org rct@frus.com ----------------------------------------------------------------------- -
Apr 27, 7:56 pm 2007
Alan Cox
BAD PATCH: USB: remove use of the bus rwsem, as it doesn't r...
Unless there is something I'm missing most of these patches seem totally Ditto ... -
Apr 27, 5:49 pm 2007
Andrew Morton
Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn'...
On Fri, 27 Apr 2007 10:42:25 -0700 Oh dear. We have an ugly i386 snafu here. Thanks for doing the bisection - it helps enormously. Could some brave person please pick it up and see if we can get both Truxton and Lee's machines working? -
Apr 27, 5:44 pm 2007
Alan Cox
BAD PATCH: IDE: remove rwsem use from ide-proc core
The semaphore is used to ensure dev->driver doesn't change under us. This patch appears to remove the neccessary locking without replacing it with anything viable. A local lock would do but the simple removal appears to -
Apr 27, 5:43 pm 2007
Alan Cox
Re: Driver core: warn when userspace writes to the uevent fi...
And checking for "add" without actually checking if count >= 3 is very ugly style indeed. Not afaict any kind of security risk as the next 3 bytes are always going to be readable -
Apr 27, 5:41 pm 2007
Tim Hockin
[PATCH] x86_64: dynamic MCE poll interval (try 2)
From: Tim Hockin <thockin@google.com> Background: We've found that MCEs (specifically DRAM SBEs) tend to come in bunches, especially when we are trying really hard to stress the system out. The current MCE poller uses a static interval which does not care whether it has or has not found MCEs recently. Description: This patch makes the MCE poller adjust the polling interval dynamically. If we find an MCE, poll 2x faster (down to 10 ms). When we stop finding MCEs, poll 2x slower (u...
Apr 27, 5:34 pm 2007
Andi Kleen Apr 27, 5:35 pm 2007
Alan Cox
Re: Driver core: warn when userspace writes to the uevent fi...
Warnings good, lack of rate limiting extremely bad indeed. -
Apr 27, 5:34 pm 2007
Alan D. Brunelle
[PATCH linux-2.6-block.git] Fix blktrace trace ordering for ...
The attached patch will correct the ordering of trace output between request queue insertions (I) and unplug calls (U). Right now the insert precedes the unplug, which just isn't right: 65,128 0 1 67.699868965 7882 Q R 0 + 1 [aiod] 65,128 0 2 67.699876462 7882 G R 0 + 1 [aiod] 65,128 0 3 67.699878286 7882 P W [aiod] 65,128 0 4 67.699880491 7882 I R 0 + 1 [aiod] 65,128 0 5 67.699887589 7882 U R [aiod] 1 65,128 0 ...
Apr 27, 4:17 pm 2007
Mauro Carvalho Chehab
[GIT PATCHES] V4L/DVB updates
Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master A short changelog: - New drivers: ivtv driver for Hauppauge PVR series and similar boards; ZR364xx USB driver; Opera S1 DVB USB driver; TDA10023 DVB frontend driver; TDA827x DVB tuner driver; - Add support for the following cards: AverMedia M102 miniPCI; Identify MSI TV@nywhere Duo; Pinnacle PCTV Sat Pro USB; Some missing Hauppau...
Apr 27, 3:59 pm 2007
Brandeburg, Jesse
[PROBLEM] 2.6.21: cpufreq panic at boot with maxcpus=1
[1.] One line summary of the problem: kernel crash at boot with maxcpus=1 on quad core [2.] Full description of the problem/report: was trying to debug something else and tried limiting kernel to 1 cpu got oops here: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/cpuf... looks like this code bugged? 1014 static int cpufreq_remove_dev (struct sys_device * sys_dev) 1015 { 1016 unsigned in...
Apr 27, 4:16 pm 2007
Greg Kroah-Hartman
[PATCH 13/46] Driver core: notify userspace of network devic...
From: Jean Tourrilhes <jt@hpl.hp.com> Provide rename event for when we rename network devices. Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject.c | 30 ++++++++++++++++++++++++++++++ net/core/net-sysfs.c | 11 +++++++++++ 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index bbbfab4..db1d237 100644 --- a/lib/...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 14/46] Driver core: suppress uevents via filter
From: Cornelia Huck <cornelia.huck@de.ibm.com> Suppress uevents for devices if uevent_suppress is set via dev_uevent_filter(). This makes the driver core suppress all device uevents, not just the add event in device_add(). Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/core.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dr...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 15/46] Driver core: switch firmware_class to uevent_s...
From: Cornelia Huck <cornelia.huck@de.ibm.com> Use uevent_suppress instead of returning an error code in firmware_uevent(). Get rid of the now unneeded FW_STATUS_READY and FW_STATUS_READY_NOHOTPLUG. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/firmware_class.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_cla...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 16/46] uevent: use add_uevent_var() instead of open c...
From: Eric Rannaud <eric.rannaud@gmail.com> Make use of add_uevent_var() instead of (often incorrectly) open coding it. Signed-off-by: Michael Ellerman <michael@ellerman.id.au> Signed-off-by: Eric Rannaud <eric.rannaud@gmail.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/amba/bus.c |...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 17/46] Driver core: add suspend() and resume() to str...
From: Dmitry Torokhov <dtor@insightbb.com> Driver core: add suspend() and resume() to struct device_type In cases when there are devices of different types in the same class we can't use class's implementation of suspend and resume methods and we need to add them to struct device_type instead. Also fix error handling in resume code (we should not try to call class's resume method iof bus's resume method for the device failed. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-o...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 18/46] Kobject: kobject_uevent.c: Collapse unnecessar...
From: John Anthony Kazos Jr <jakj@j-a-k-j.com> Collapses a do..while() loop within an if() to a simple while() loop for simplicity and readability. Signed-off-by: John Anthony Kazos Jr. <jakj@j-a-k-j.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject_uevent.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 4122f38..d9a3510 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 19/46] kobject: kobject_add() reference leak
From: Cornelia Huck <cornelia.huck@de.ibm.com> We leak a reference if we attempt to add a kobject with no name. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index db1d237..eb251aa 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -174,6 +174,7 @@ int kobject_shadow_add(struct kobject * kobj, s...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 20/46] Driver core: remove use of rwsem
This lock is never used by the rest of the driver core, so the fact that we are grabbing it here means it isn't correct... Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/power/shutdown.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/shutdown.c b/drivers/base/power/shutdown.c index 3483ae4..58b6f77 100644 --- a/drivers/base/power/shutdown.c +++ b/drivers/base/power/shutdown.c @@ -36,7 +36,6 @@ void device_shutdown(void) ...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 21/46] SCSI: use the proper semaphore to protect the ...
SCSI was using the incorrect lock to protect walking the list of all devices in the class. This patch fixes this. Cc: James Bottomley <James.Bottomley@SteelEye.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/scsi/hosts.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 38c3a29..bd8e7f3 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -435,7 +435,7 @@ struct Scsi_Host *s...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 22/46] USB: remove use of the bus rwsem, as it doesn'...
The driver core stopped using the rwsem a long time ago, yet the USB core still grabbed the lock, thinking it protected something. This patch removes that useless use. Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Oliver Neukum <oneukum@suse.de> Cc: David Brownell <david-b@pacbell.net> Cc: linux-usb-devel <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/usb/core/devices.c | 2 -- drivers/usb/core/devio.c ...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 23/46] PNP: stop using the subsystem rwsem
The rwsem is not used to protect anything, so the use of it by the PNP subsystem isn't really useful, and it's doubtful if it really did anything or not. So I've removed it. Cc: Adam Belay <ambx1@neo.rr.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/pnp/card.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c index 91c047a..dd6384b 100644 --- a/drivers/pnp/card.c +++ b/drivers/pnp/card.c @@ ...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 24/46] Input: serio - do not touch bus's rwsem
From: Dmitry Torokhov <dtor@insightbb.com> The subsystem rwsem is not used by the driver core at all, so there is no point in trying to access it. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/input/serio/serio.c | 41 +++++++++++++++-------------------------- 1 files changed, 15 insertions(+), 26 deletions(-) diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c index a15e531..5895202 100644 ...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 25/46] Input: gameport - do not touch bus's rwsem
From: Dmitry Torokhov <dtor@insightbb.com> The subsystem rwsem is not used by the driver core at all, so there is no point in trying to access it. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/input/gameport/gameport.c | 39 ++++++++++++------------------------ 1 files changed, 13 insertions(+), 26 deletions(-) diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c index a00fe47..bd...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 26/46] IDE: remove rwsem use from ide-proc core
The subsystem rwsem is not used by the driver core at all, so the use of it in the ide-proc code of it doesn't make any sense. Perhaps a local lock might be needed, but I do not really think so. Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Cc: linux ide <linux-ide@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/ide/ide-proc.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/ide/ide-proc.c b/drivers/ide/i...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 27/46] IEEE1394: remove rwsem use from ieee1394 core
The subsystem rwsem is not used by the driver core at all, so the use of it in the ieee1394 code doesn't make any sense. They might possibly want to use a local lock, but as most of these operations are already protected by a local lock, it really doesn't look like it would be needed. Cc: Ben Collins <bcollins@debian.org> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: linux1394-devel <linux1394-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de...
Apr 27, 2:53 pm 2007
Greg Kroah-Hartman
[PATCH 28/46] PHY: remove rwsem use from phy core
The subsystem rwsem is not used by the driver core at all, so the use of it in the phy code doesn't make any sense. They might possibly want to use a local lock, but I am unsure about that. Cc: netdev <netdev@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/net/phy/fixed.c | 6 ------ drivers/net/phy/phy_device.c | 9 +-------- 2 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c ...
Apr 27, 2:53 pm 2007
Andy Fleming
Re: [PATCH 28/46] PHY: remove rwsem use from phy core
I think I copied that code from elsewhere without truly understanding it. *bows head in shame* As such, I have no objection to this patch unless someone says it -
Apr 27, 5:11 pm 2007
previous daytodaynext day
April 26, 2007April 27, 2007April 28, 2007