[patch] uml: fix cmpxchg warnings in -mm

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <jdike@...>
Cc: <linux-kernel@...>, <user-mode-linux-devel@...>
Date: Friday, April 27, 2007 - 12:18 pm

From: Miklos Szeredi <mszeredi@suse.cz>

I get lot's of these on i386:

In file included from include/asm/atomic.h:10,
                 from include/linux/file.h:9,
                 from mm/fadvise.c:12:
include/asm/arch/atomic.h: In function ‘atomic_add_unless’:
include/asm/arch/atomic.h:240: warning: implicit declaration of function ‘cmpxchg’
[...]

The problem seems to be that <asm-i386/atomic.h> assumes that
<asm/processor.h> pulls in <asm/system.h>.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---

Index: linux/include/asm-um/processor-i386.h
===================================================================
--- linux.orig/include/asm-um/processor-i386.h	2007-04-26 15:16:47.000000000 +0200
+++ linux/include/asm-um/processor-i386.h	2007-04-27 17:58:25.000000000 +0200
@@ -9,6 +9,7 @@
 #include "linux/string.h"
 #include "asm/host_ldt.h"
 #include "asm/segment.h"
+#include "asm/system.h"
 
 extern int host_has_xmm;
 extern int host_has_cmov;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] uml: fix cmpxchg warnings in -mm, Miklos Szeredi, (Fri Apr 27, 12:18 pm)
Re: [patch] uml: fix cmpxchg warnings in -mm, Sam Ravnborg, (Fri Apr 27, 1:27 pm)
Re: [patch] uml: fix cmpxchg warnings in -mm, Jeff Dike, (Fri Apr 27, 1:35 pm)
[patch] uml: remove #warnings, Miklos Szeredi, (Fri Apr 27, 12:19 pm)