As the changes became, smaller the builds became quicker :-) and after 7
iterations we have:
author Neil Horman <nhorman@tuxdriver.com>
Fri, 20 Apr 2007 13:54:58 +0000 (09:54 -0400)
committer Jeff Garzik <jeff@garzik.org>
Tue, 24 Apr 2007 16:43:07 +0000 (12:43 -0400)
commit b748d9e3b80dc7e6ce6bf7399f57964b99a4104c
tree 887909e1f735bb444ef0e3e370f34401fa6eee02 tree | snapshot
parent d91c088b39e3c66d309938de858775bb90fd1ead commit | diff
sis900: Allocate rx replacement buffer before rx operation
The sis900 driver appears to have a bug in which the receive routine
passes the skbuff holding the received frame to the network stack before
refilling the buffer in the rx ring. If a new skbuff cannot be
allocated, the
driver simply leaves a hole in the rx ring, which causes the driver to stop
receiving frames and become non-recoverable without an rmmod/insmod
according to
reporters. This patch reverses that order, attempting to allocate a
replacement
buffer first, and receiving the new frame only if one can be allocated.
If no
skbuff can be allocated, the current skbuf in the rx ring is recycled,
dropping
the current frame, but keeping the NIC operational.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Peter
--
Peter Williams pwil3058@bigpond.net.au
"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
-
