Re: [PATCH] cancel_delayed_work: use del_timer() instead of del_timer_sync()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: David Howells

Subject: Re: [PATCH] cancel_delayed_work: use del_timer() instead of del_timer_sync()

Date: Wednesday, April 25, 2007 - 3:04 am

Oleg Nesterov <oleg@tv-sign.ru> wrote:

quoted text> del_timer_sync() buys nothing for cancel_delayed_work(), but it is less
> efficient since it locks the timer unconditionally, and may wait for the
> completion of the delayed_work_timer_fn().

Okay, this patch seems to work for me, though I'm not using any of the other
related patches that are in the -mm tree (I modified this patch to compile
directly on top of Linus's vanilla tree).

Acked-By: David Howells <dhowells@redhat.com>
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] cancel_delayed_work: use del_timer() instead of de ..., Oleg Nesterov, (Tue Apr 24, 2:50 pm)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., David Howells, (Wed Apr 25, 3:04 am)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., Oleg Nesterov, (Wed Apr 25, 5:52 am)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., Jarek Poplawski, (Wed Apr 25, 6:02 am)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., Jarek Poplawski, (Thu Apr 26, 7:29 am)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., Oleg Nesterov, (Thu Apr 26, 8:29 am)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., Jarek Poplawski, (Thu Apr 26, 11:15 pm)

Re: [PATCH] cancel_delayed_work: use del_timer() instead o ..., Oleg Nesterov, (Fri Apr 27, 12:23 am)


linux-kernel:
David Howells	[PATCH] KEYS: Use the variable 'key' in keyctl_describe_key()
Greg Kroah-Hartman	[PATCH 17/36] sysdev: detect multiple driver registrations
Sam Ravnborg	Re: [PATCH] kbuild: fix make V=1
Nick Piggin	Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
Matthew Garrett	Re: [linux-pm] [PATCH] Remove process freezer from suspend to RAM pathway
git:
Pat Thoyts	[PATCH] git-gui: use themed tk widgets with Tk 8.5
Stephen R. van den Berg	Re: [RFC] origin link for cherry-pick and revert
Johannes Schindelin	Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Junio C Hamano	Re: [PATCH 6/6] Teach core object handling functions about gitlinks
Michael S. Tsirkin	git-kill: rewrite history removing a commit
linux-netdev:
Jan Engelhardt	[PATCH 1/3] net: tcp: make hybla selectable as default congestion module
Jarek Poplawski	Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
Lennert Buytenhek	Re: Distributed Switch Architecture(DSA)
Daniel Schaffrath	Re: tcp bw in 2.6
Matt Mackall	Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
git-commits-head:
Linux Kernel Mailing List	ipv6: fix an oops when force unload ipv6 module
Linux Kernel Mailing List	tracing: protect reader of cmdline output
Linux Kernel Mailing List	kconfig: recalc symbol value before showing search results
Linux Kernel Mailing List	KVM: VMX: Clear CR4.VMXE in hardware_disable
Linux Kernel Mailing List	USB: set correct configuration in probe of ti_usb_3410_5052
openbsd-misc:
Claudio Jeker	Re: Vlan Tag on Vlan Tag (l2tunneling)
Josh Grosse	ssh/sshd challenge-response seems to have stopped working in -current
Tomas Bodzar	bsd: uvm_mapent_alloc: out of static map entries
Community First Financial	Teacher A+ Loan
Pieter Verberne	File collision while using pkg_add