Re: [RFC 0/8] Variable Order Page Cache

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: William Lee Irwin III
Date: Thursday, April 19, 2007 - 11:22 pm

On Thu, 19 Apr 2007, William Lee Irwin III wrote:

On Thu, Apr 19, 2007 at 10:27:34PM -0700, Christoph Lameter wrote:

I'm not sure how to say this politely, so please don't take it as a
slight. Hacks to avoid diffsize increases that would result from data
structure code are highly specious. There are typically functionality
or efficiency issues deliberately left unaddressed to accomplish such.
When committing the patch, you generally end up implicitly committed
to later updates to address those issues.

That said, even if some maintainers consciously agree (it's actually
rather clear that my opinion here is not representative of the majority
if anyone else at all), it does still present an issue for "marketing"
patches since diffsize is so easily latched onto as a metric of risk.

Don't worry about it for now. This will do fine.


On Thu, 19 Apr 2007, William Lee Irwin III wrote:

On Thu, Apr 19, 2007 at 10:27:34PM -0700, Christoph Lameter wrote:

They're all TLB so picking things up on the TLB side can be done there.
I think they also keep the long format VHPT code updated to recent
mainline, which makes higher-order pages meaningful on ia64 (which with
the region register -based affair they are effectively not).


On Thu, 19 Apr 2007, William Lee Irwin III wrote:

On Thu, Apr 19, 2007 at 10:27:34PM -0700, Christoph Lameter wrote:

A more careful reading would reveal this as a criticism of industrial
sponsorship of research, not academia per se. For instance, what IHV
would bother sponsoring research on page replacement, since when
grinding out [trademarked name of major benchmark censored] numbers to
sell their systems, they arrange for page replacement never to happen?


-- wli
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 1/8] Add order field to address_space struct, Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 2/8] Basic allocation for higher order page cache pages, Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 3/8] Flushing and zeroing higher order page cache pages, Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 4/8] Enhance fallback functions in libs to support hi ..., Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 5/8] Enhance generic_read/write to support higher ord ..., Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 6/8] Account for pages in the page cache in terms of ..., Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Thu Apr 19, 9:35 am)
[RFC 8/8] Add some debug output, Christoph Lameter, (Thu Apr 19, 9:35 am)
Re: [RFC 6/8] Account for pages in the page cache in terms ..., Christoph Lameter, (Thu Apr 19, 10:52 am)
Re: [RFC 0/8] Variable Order Page Cache, Badari Pulavarty, (Thu Apr 19, 12:09 pm)
Re: [RFC 4/8] Enhance fallback functions in libs to suppor ..., Christoph Lameter, (Thu Apr 19, 12:10 pm)
Re: [RFC 0/8] Variable Order Page Cache, Andi Kleen, (Thu Apr 19, 12:11 pm)
Re: [RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Thu Apr 19, 12:12 pm)
Re: [RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Thu Apr 19, 12:15 pm)
Re: [RFC 0/8] Variable Order Page Cache, David Chinner, (Thu Apr 19, 3:42 pm)
Re: [RFC 0/8] Variable Order Page Cache, Maxim Levitsky, (Thu Apr 19, 4:58 pm)
Re: [RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Thu Apr 19, 6:14 pm)
Re: [RFC 4/8] Enhance fallback functions in libs to suppor ..., Christoph Lameter, (Thu Apr 19, 6:15 pm)
Re: [RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Thu Apr 19, 6:15 pm)
Re: [RFC 0/8] Variable Order Page Cache, William Lee Irwin III, (Thu Apr 19, 9:47 pm)
Re: [RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Thu Apr 19, 10:27 pm)
Re: [RFC 0/8] Variable Order Page Cache, William Lee Irwin III, (Thu Apr 19, 11:22 pm)
Re: [RFC 0/8] Variable Order Page Cache, Jens Axboe, (Thu Apr 19, 11:32 pm)
Re: [RFC 0/8] Variable Order Page Cache, David Chinner, (Fri Apr 20, 12:48 am)
Re: [RFC 0/8] Variable Order Page Cache, David Chinner, (Fri Apr 20, 1:42 am)
Re: [RFC 0/8] Variable Order Page Cache, Mel Gorman, (Fri Apr 20, 7:14 am)
Re: [RFC 0/8] Variable Order Page Cache, Mel Gorman, (Fri Apr 20, 7:37 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, William Lee Irwin III, (Fri Apr 20, 7:47 am)
Re: [RFC 4/8] Enhance fallback functions in libs to suppor ..., Christoph Lameter, (Fri Apr 20, 9:01 am)
Re: [RFC 3/8] Flushing and zeroing higher order page cache ..., Christoph Lameter, (Fri Apr 20, 9:15 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 9:20 am)
Re: [RFC 0/8] Variable Order Page Cache, Christoph Lameter, (Fri Apr 20, 9:23 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 9:30 am)
Re: [RFC 3/8] Flushing and zeroing higher order page cache ..., William Lee Irwin III, (Fri Apr 20, 9:51 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, William Lee Irwin III, (Fri Apr 20, 10:11 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 10:15 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, William Lee Irwin III, (Fri Apr 20, 10:19 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 10:57 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 10:59 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 11:01 am)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, Christoph Lameter, (Fri Apr 20, 11:02 am)
Re: [RFC 4/8] Enhance fallback functions in libs to suppor ..., Christoph Lameter, (Fri Apr 20, 12:10 pm)
Re: [RFC 7/8] Enhance ramfs to support higher order pages, William Lee Irwin III, (Fri Apr 20, 12:21 pm)
Re: [RFC 0/8] Variable Order Page Cache, Andrew Morton, (Sat Apr 21, 3:18 pm)