Re: Could the k8temp driver be interfering with ACPI?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jean Delvare <khali@...>
Cc: Pavel Machek <pavel@...>, Len Brown <len.brown@...>, Matthew Garrett <mjg59@...>, Chuck Ebbert <cebbert@...>, Rudolf Marek <r.marek@...>, <linux-acpi@...>, linux-kernel <linux-kernel@...>, <lm-sensors@...>
Date: Monday, April 2, 2007 - 3:22 pm

On Mon, Apr 02, 2007 at 05:48:59PM +0200, Jean Delvare wrote:
 > +	u8  val;
 > +#ifdef CONFIG_ACPI
 > +	acpi_ut_acquire_mutex(ACPI_MTX_INTERPRETER);
 > +#endif
 >  	outb(reg, data->addr + ADDR_REG_OFFSET);
 > -	return inb(data->addr + DATA_REG_OFFSET);
 > +	val = inb(data->addr + DATA_REG_OFFSET);
 > +#ifdef CONFIG_ACPI
 > +	acpi_ut_release_mutex(ACPI_MTX_INTERPRETER);
 > +#endif
 > +	return val;
 > ... deletia, more of the same.

it'd probably end up a lot cleaner to #define them to empty macros
in the !ACPI case in acpi/acpi.h and just #include it unconditionally.

	Dave

-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Could the k8temp driver be interfering with ACPI?, Chuck Ebbert, (Fri Feb 16, 1:31 pm)
Re: [lm-sensors] Could the k8temp driver be interfering with..., Alexey Starikovskiy, (Fri Mar 9, 6:39 am)
Re: [lm-sensors] Could the k8temp driver be interfering with..., Alexey Starikovskiy, (Fri Mar 9, 1:35 pm)
Re: [lm-sensors] Could the k8temp driver be interfering with..., richardvoigt@gmail.com, (Sun Mar 18, 3:36 pm)
Re: Could the k8temp driver be interfering with ACPI?, Jean Delvare, (Mon Apr 2, 11:48 am)
RE: Could the k8temp driver be interfering with ACPI?, Moore, Robert, (Mon Apr 2, 4:55 pm)
Re: Could the k8temp driver be interfering with ACPI?, Jean Delvare, (Tue Apr 3, 3:21 am)
RE: Could the k8temp driver be interfering with ACPI?, Moore, Robert, (Wed Apr 4, 5:35 pm)
Re: Could the k8temp driver be interfering with ACPI?, Dave Jones, (Mon Apr 2, 3:22 pm)
Re: Could the k8temp driver be interfering with ACPI?, Jean Delvare, (Tue Apr 3, 1:49 am)
Re: [lm-sensors] Could the k8temp driver be interfering with..., Henrique de Moraes Holschuh..., (Fri Mar 2, 5:22 pm)
Re: [lm-sensors] Could the k8temp driver be interfering with..., Henrique de Moraes Holschuh..., (Fri Mar 2, 9:47 am)
Re: Could the k8temp driver be interfering with ACPI?, Chuck Ebbert, (Fri Feb 16, 3:31 pm)
Re: Could the k8temp driver be interfering with ACPI?, Chuck Ebbert, (Fri Feb 16, 2:14 pm)