* Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:ok. But the only real problem would be for_each_online_cpu() loops that might sleep, correct? I did a quick audit and those seem to be in the minority by a factor of 1:10. So ... to make the audit obviously safe, how about mechanically converting 100% of the for_each_online_cpu() loops to something like: mask = get_each_online_cpu_mask(); for_each_cpu_mask(mask) { ... } put_each_online_cpu_mask(mask); where get_each_online_cpu_mask() also does a preempt_disable() implicitly, and put_each_online_cpu_mask() does a preempt_enable(). (Note that no locking is needed - only preemption-disabling.) the 10% loops that _can_ schedule would trigger the __might_sleep() atomicity test in schedule()), and those would have to be converted a bit more cleverly, on a case by case basis. (for example a number of them might not even have to sleep on the for_each_online_cpu() loop) hm? Ingo -
| Andrew Morton | -mm merge plans for 2.6.23 |
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| Greg KH | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Tomasz Kłoczko | Is it time for remove (crap) ALSA from kernel tree ? |
git: | |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | [GIT]: Networking |
| Paweł Staszewski | iproute2 action/policer question |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
