login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
April
»
19
Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Rafael J. Wysocki
Subject:
Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
Date: Thursday, April 19, 2007 - 2:39 pm
Hi, On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote:
quoted text
> This patch fixes the race pointed out by Oleg Nesterov. > > * Freezer marks a thread as freezeable. > * The thread now marks itself PF_NOFREEZE causing it to > freeze on calling try_to_freeze(). Thus the task is frozen, even though > it doesn't want to. > * Subsequent thaw_processes() will also fail to thaw the task since it is > marked PF_NOFREEZE. > > Avoid this problem by checking the current task's PF_NOFREEZE status in the > refrigerator before marking current as frozen. > > Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
Looks good, although I'm not sure if we don't need to call recalc_sigpending() for tasks that turn out to be PF_NOFREEZE. Greetings, Rafael -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RFC 0/2] Fix Freezer related races.
, Gautham R Shenoy
, (Thu Apr 19, 5:01 am)
[RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
, Gautham R Shenoy
, (Thu Apr 19, 5:02 am)
[RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop race
, Gautham R Shenoy
, (Thu Apr 19, 5:04 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Andrew Morton
, (Thu Apr 19, 2:31 pm)
Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
, Rafael J. Wysocki
, (Thu Apr 19, 2:39 pm)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Rafael J. Wysocki
, (Fri Apr 20, 1:54 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Gautham R Shenoy
, (Fri Apr 20, 3:46 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Gautham R Shenoy
, (Fri Apr 20, 4:05 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Rafael J. Wysocki
, (Fri Apr 20, 4:59 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Gautham R Shenoy
, (Fri Apr 20, 5:26 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Rafael J. Wysocki
, (Fri Apr 20, 5:50 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Andrew Morton
, (Fri Apr 20, 10:30 am)
Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
, Oleg Nesterov
, (Fri Apr 20, 11:02 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Ingo Molnar
, (Fri Apr 20, 11:31 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Oleg Nesterov
, (Fri Apr 20, 2:12 pm)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Rafael J. Wysocki
, (Fri Apr 20, 2:13 pm)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Oleg Nesterov
, (Fri Apr 20, 2:20 pm)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Rafael J. Wysocki
, (Fri Apr 20, 2:45 pm)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Pavel Machek
, (Sat Apr 21, 2:37 am)
[RFC][PATCH -mm 0/3] Separate freezer flags
, Rafael J. Wysocki
, (Sun Apr 22, 12:28 pm)
[RFC][PATCH -mm 1/3] Separate freezer from PM code
, Rafael J. Wysocki
, (Sun Apr 22, 12:33 pm)
[RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Sun Apr 22, 12:39 pm)
[RFC][PATCH -mm 3/3] freezer: Fix problem with kthread_stop
, Rafael J. Wysocki
, (Sun Apr 22, 12:40 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Paul Jackson
, (Sun Apr 22, 2:14 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Sun Apr 22, 3:14 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Paul Jackson
, (Sun Apr 22, 3:31 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Satyam Sharma
, (Sun Apr 22, 8:18 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Satyam Sharma
, (Sun Apr 22, 9:09 pm)
Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
, Gautham R Shenoy
, (Mon Apr 23, 3:26 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Gautham R Shenoy
, (Mon Apr 23, 3:38 am)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Pavel Machek
, (Mon Apr 23, 3:40 am)
Re: [RFC][PATCH -mm 1/3] Separate freezer from PM code
, Pavel Machek
, (Mon Apr 23, 3:41 am)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Pavel Machek
, (Mon Apr 23, 3:50 am)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Gautham R Shenoy
, (Mon Apr 23, 5:35 am)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Gautham R Shenoy
, (Mon Apr 23, 6:17 am)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Gautham R Shenoy
, (Mon Apr 23, 7:19 am)
Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
, Oleg Nesterov
, (Mon Apr 23, 10:49 am)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Oleg Nesterov
, (Mon Apr 23, 11:39 am)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Mon Apr 23, 11:49 am)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Oleg Nesterov
, (Mon Apr 23, 12:03 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Mon Apr 23, 12:06 pm)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Rafael J. Wysocki
, (Mon Apr 23, 12:50 pm)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Rafael J. Wysocki
, (Mon Apr 23, 12:55 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Mon Apr 23, 12:57 pm)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Rafael J. Wysocki
, (Mon Apr 23, 1:05 pm)
Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop ...
, Gautham R Shenoy
, (Mon Apr 23, 1:34 pm)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Oleg Nesterov
, (Mon Apr 23, 1:46 pm)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Gautham R Shenoy
, (Mon Apr 23, 2:16 pm)
Re: [RFC][PATCH -mm 3/3] freezer: Fix problem with kthread ...
, Rafael J. Wysocki
, (Mon Apr 23, 2:30 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Oleg Nesterov
, (Mon Apr 23, 3:23 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Mon Apr 23, 3:40 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Gautham R Shenoy
, (Mon Apr 23, 3:41 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Mon Apr 23, 3:55 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Oleg Nesterov
, (Mon Apr 23, 3:55 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Mon Apr 23, 4:10 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Oleg Nesterov
, (Mon Apr 23, 4:19 pm)
Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
, Rafael J. Wysocki
, (Tue Apr 24, 4:32 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Fortier,Vincent [Montreal]
2.6.21.5 june 30th to july 1st date hang?
Jeff Dike
[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood
[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov
Re: Getting the new RxRPC patches upstream
Stefan Seyfried
Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev
:
Arnaud Ebalard
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt
Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior
[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git
:
Jakub Narebski
Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey
Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder
[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra
Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano
Re: git-rm isn't the inverse action of git-add
openbsd-misc
:
Joachim Schipper
Re: UVC Webcams
Florin Andrei
SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith
Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan
Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.
Re: Real men don't attack straw men
git-commits-head
:
Linux Kernel Mailing List
ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List
m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List
[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List
[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List
mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()
Colocation donated by:
Syndicate