Home » Mailing list archives » linux-kernel » 2007 » April » 19

[PATCH] lockdep: lookup_chain_cache comment errata

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jarek Poplawski <jarkao2@...>
To: <linux-kernel@...>
Cc: Ingo Molnar <mingo@...>
Subject: [PATCH] lockdep: lookup_chain_cache comment errata
Date: Thursday, April 19, 2007 - 5:34 am

[PATCH] lockdep: lookup_chain_cache comment errata

Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>

---

diff -Nurp 2.6.21-rc7-/kernel/lockdep.c 2.6.21-rc7/kernel/lockdep.c
--- 2.6.21-rc7-/kernel/lockdep.c	2007-04-18 10:14:06.000000000 +0200
+++ 2.6.21-rc7/kernel/lockdep.c	2007-04-19 11:25:40.000000000 +0200
@@ -1313,8 +1313,9 @@ out_unlock_set:
 
 /*
  * Look up a dependency chain. If the key is not present yet then
- * add it and return 0 - in this case the new dependency chain is
- * validated. If the key is already hashed, return 1.
+ * add it and return 1 - in this case the new dependency chain is
+ * validated. If the key is already hashed, return 0.
+ * (On return with 1 graph_lock is held.)
  */
 static inline int lookup_chain_cache(u64 chain_key, struct lock_class *class)
 {
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] lockdep: lookup_chain_cache comment errata, Jarek Poplawski, (Thu Apr 19, 5:34 am)
Re: [PATCH] lockdep: lookup_chain_cache comment errata, Ingo Molnar, (Thu Apr 19, 5:30 am)