Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Thursday, April 12, 2007 - 2:36 am

> OK, so I resurrected x86_64-mm-sched-clock-share.patch and

Ah. But ktime_get shouldn't printk. Or did you change that?


Just use jiffies directly in printk. That's only HZ accurate, but should
be good enough for printk.  

One could use pure monotonic xtime as fallback instead of ktime_get in sched_clock. 
The trouble is  just that they might cause sched_clock to go backwards during 
a temporary instability period (cpufreq change) because the xtime will be 
always a bit behind the TSC and a TSC->xtime conversion will lose time.
At least the scheduler doesn't handle backwards time warp on a CPU gratefully.
Ok I guess it could  return max(last_value_before_instability, xtime) 

-Andi


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq ..., Andi Kleen, (Thu Apr 12, 2:36 am)
Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq ..., Jeremy Fitzhardinge, (Thu Apr 12, 10:41 am)
Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq ..., Jeremy Fitzhardinge, (Thu Apr 12, 10:43 am)
Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq ..., Jeremy Fitzhardinge, (Thu Apr 12, 12:41 pm)
Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq ..., Jeremy Fitzhardinge, (Thu Apr 12, 12:43 pm)
Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq ..., Jeremy Fitzhardinge, (Thu Apr 12, 12:46 pm)