[patch] enhance initcall_debug, measure latency

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Andrew Morton <akpm@...>
Date: Sunday, April 1, 2007 - 2:16 pm

Subject: [patch] enhance initcall_debug, measure latency
From: Ingo Molnar <mingo@elte.hu>

enhance the initcall_debug boot option:

 - measure the time the initcall took to execute and report
   it in units of milliseconds.

 - show the return code of initcalls (useful to see failures and
   to make sure that an initcall hung)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 init/main.c |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Index: linux/init/main.c
===================================================================
--- linux.orig/init/main.c
+++ linux/init/main.c
@@ -685,6 +685,7 @@ static void __init do_initcalls(void)
 	int count = preempt_count();
 
 	for (call = __initcall_start; call < __initcall_end; call++) {
+		ktime_t t0, t1, delta;
 		char *msg = NULL;
 		char msgbuf[40];
 		int result;
@@ -694,10 +695,26 @@ static void __init do_initcalls(void)
 			print_fn_descriptor_symbol(": %s()",
 					(unsigned long) *call);
 			printk("\n");
+			t0 = ktime_get();
 		}
 
 		result = (*call)();
 
+		if (initcall_debug) {
+			t1 = ktime_get();
+			delta = ktime_sub(t1, t0);
+
+			printk("initcall 0x%p", *call);
+			print_fn_descriptor_symbol(": %s()",
+					(unsigned long) *call);
+			printk(" returned %d.\n", result);
+
+			printk("initcall 0x%p ran for %Ld msecs: ",
+				*call, delta.tv64 >> 20);
+			print_fn_descriptor_symbol("%s()\n",
+				(unsigned long) *call);
+		}
+
 		if (result && result != -ENODEV && initcall_debug) {
 			sprintf(msgbuf, "error code %d", result);
 			msg = msgbuf;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] enhance initcall_debug, measure latency, Ingo Molnar, (Sun Apr 1, 2:16 pm)
Re: [patch] enhance initcall_debug, measure latency, Andrew Morton, (Mon Apr 2, 1:50 am)
Re: [patch] enhance initcall_debug, measure latency, Ingo Molnar, (Sun Apr 1, 2:28 pm)
Re: [patch] enhance initcall_debug, measure latency, Andi Kleen, (Mon Apr 2, 4:00 am)
Re: [patch] enhance initcall_debug, measure latency, Ingo Molnar, (Mon Apr 2, 3:09 am)
Re: [patch] enhance initcall_debug, measure latency, Andi Kleen, (Mon Apr 2, 3:22 am)
Re: [patch] enhance initcall_debug, measure latency, Ingo Molnar, (Mon Apr 2, 2:04 am)