Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Andrew Morton

Subject: Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

Date: Wednesday, March 7, 2007 - 4:00 pm

On Wed, 7 Mar 2007 23:41:16 +0100
Adrian Bunk <bunk@stusta.de> wrote:

quoted text> On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.20-rc2-mm1:
> >...
> >  git-netdev-all.patch
> >...
> >  git trees
> >...
> 
> drivers/net/wireless/libertas/debugfs.c contains:
>   #define item_addr(n) ((u32) &((wlan_adapter *)0)->n)
> 
> This is wrong on 64bit architectures.

Is OK - it is simply yet another reimplementation of offsetof().  Hint.
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

2.6.21-rc2-mm2, Andrew Morton, (Tue Mar 6, 1:44 am)

Re: 2.6.21-rc2-mm2, J.A. , (Tue Mar 6, 2:06 am)

Re: 2.6.21-rc2-mm2, Andrew Morton, (Tue Mar 6, 2:15 am)

Re: 2.6.21-rc2-mm2, J.A. , (Tue Mar 6, 2:38 am)

Re: 2.6.21-rc2-mm2, Andrew Morton, (Tue Mar 6, 2:42 am)

Re: 2.6.21-rc2-mm2, J.A. , (Tue Mar 6, 2:44 am)

Re: 2.6.21-rc2-mm2, KAMEZAWA Hiroyuki, (Tue Mar 6, 3:27 am)

Re: 2.6.21-rc2-mm2, Andrew Morton, (Tue Mar 6, 4:09 am)

Re: 2.6.21-rc2-mm2, Jens Axboe, (Tue Mar 6, 4:14 am)

Re: 2.6.21-rc2-mm2, KAMEZAWA Hiroyuki, (Tue Mar 6, 4:35 am)

Re: 2.6.21-rc2-mm2, Con Kolivas, (Tue Mar 6, 4:58 am)

Re: 2.6.21-rc2-mm2, Thomas Gleixner, (Tue Mar 6, 5:52 am)

Re: 2.6.21-rc2-mm2, Con Kolivas, (Tue Mar 6, 6:24 am)

Re: 2.6.21-rc2-mm2, Thomas Gleixner, (Tue Mar 6, 7:47 am)

Re: 2.6.21-rc2-mm2, J.A. , (Tue Mar 6, 8:46 am)

Re: 2.6.21-rc2-mm2, Con Kolivas, (Tue Mar 6, 1:19 pm)

[BUGFIX][PATCH] fix NULL pointer in ia64/irq_chip-mask/unm ..., KAMEZAWA Hiroyuki, (Tue Mar 6, 11:23 pm)

Re: 2.6.21-rc2-mm2, Jean Delvare, (Tue Mar 6, 11:24 pm)

Re: [BUGFIX][PATCH] fix NULL pointer in ia64/irq_chip-mask ..., Andrew Morton, (Tue Mar 6, 11:57 pm)

Re: [BUGFIX][PATCH] fix NULL pointer in ia64/irq_chip-mask ..., KAMEZAWA Hiroyuki, (Wed Mar 7, 12:32 am)

Re: 2.6.21-rc2-mm2, Sébastien Dugué, (Wed Mar 7, 1:39 am)

Re: 2.6.21-rc2-mm2, Andrew Morton, (Wed Mar 7, 1:49 am)

Re: 2.6.21-rc2-mm2, Sébastien Dugué, (Wed Mar 7, 2:30 am)

Re: 2.6.21-rc2-mm2, Luiz Fernando N. Cap ..., (Wed Mar 7, 12:46 pm)

Re: 2.6.21-rc2-mm2, Andrew Morton, (Wed Mar 7, 12:52 pm)

Re: 2.6.21-rc2-mm2 hang, Dave Hansen, (Wed Mar 7, 3:12 pm)

[RFC: -mm patch] #if 0 mmc_deselect_cards(), Adrian Bunk, (Wed Mar 7, 3:41 pm)

2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c ad ..., Adrian Bunk, (Wed Mar 7, 3:41 pm)

Re: 2.6.21-rc2-mm2 hang, Andrew Morton, (Wed Mar 7, 3:46 pm)

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs. ..., Andrew Morton, (Wed Mar 7, 4:00 pm)

e1000 oops on boot [Re: 2.6.21-rc2-mm2], J.A. , (Wed Mar 7, 5:03 pm)

Re: e1000 oops on boot [Re: 2.6.21-rc2-mm2], Andrew Morton, (Wed Mar 7, 5:23 pm)

Re: e1000 oops on boot [Re: 2.6.21-rc2-mm2], Randy Dunlap, (Wed Mar 7, 5:28 pm)

Re: e1000 oops on boot [Re: 2.6.21-rc2-mm2], Kok, Auke, (Wed Mar 7, 5:35 pm)

Re: 2.6.21-rc2-mm2 hang, Siddha, Suresh B, (Wed Mar 7, 6:07 pm)

Re: [RFC: -mm patch] #if 0 mmc_deselect_cards(), Pierre Ossman, (Wed Mar 7, 10:47 pm)

MMC: Fix typo in mmc highspeed, Kyungmin Park, (Wed Mar 7, 11:31 pm)

Re: 2.6.21-rc2-mm2, Mike Galbraith, (Thu Mar 8, 12:20 am)

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs. ..., Adrian Bunk, (Thu Mar 8, 1:02 am)

Re: 2.6.21-rc2-mm2, Magnus Damm, (Thu Mar 8, 1:41 am)

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs. ..., Tony Breeds, (Thu Mar 8, 7:11 pm)

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs. ..., John W. Linville, (Fri Mar 9, 7:19 am)

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs. ..., Randy Dunlap, (Fri Mar 9, 10:14 am)

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs. ..., Tony Breeds, (Sun Mar 11, 8:43 pm)

[-mm patch] remove mmc_deselect_cards(), Adrian Bunk, (Mon Mar 19, 2:21 am)


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney	[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger	[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha	[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc:
Theo de Raadt	Re: Old IPSEC bug
Tomáš Bodžár	Problem with vpnc connection - check group password !
Insan Praja SW	Mandoc Compiling Error
Carl Roberso	Re: Cannot change MTU of carp interface?
Richard Daemon	Re: booting openbsd on eee without cd-rom