Home » Mailing list archives » linux-kernel » 2007 » March » 7

[PATCH] x86_64 RESTORE_CONTEXT missing '\n'

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jiang <djiang@...>
To: <linux-kernel@...>
Cc: <ak@...>, <trini@...>, <sshtylyov@...>
Subject: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'
Date: Wednesday, March 7, 2007 - 4:45 pm

The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in the
previous patch that touched system.h. It causes compile failure if any
inline asm is added after the macro. Discovered this when playing with
kgdb.

Signed-off-by: Dave Jiang <djiang@mvista.com>

---

 include/asm-x86_64/system.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

---

diff --git a/include/asm-x86_64/system.h b/include/asm-x86_64/system.h
index bd376bc..cbb8579 100644
--- a/include/asm-x86_64/system.h
+++ b/include/asm-x86_64/system.h
@@ -15,7 +15,7 @@
 
 /* frame pointer must be last for get_wchan */
 #define SAVE_CONTEXT    "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t"
-#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"
+#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\n\t"
 
 #define __EXTRA_CLOBBER  \
 	,"rcx","rbx","rdx","r8","r9","r10","r11","r12","r13","r14","r15"
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] x86_64 RESTORE_CONTEXT missing '\n', Dave Jiang, (Wed Mar 7, 4:45 pm)
Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Andi Kleen, (Thu Mar 8, 1:14 pm)
Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Dave Jiang, (Thu Mar 8, 1:44 pm)
Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Andi Kleen, (Thu Mar 8, 2:37 pm)
Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Tom Rini, (Thu Mar 8, 2:49 pm)
Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Andi Kleen, (Thu Mar 8, 6:36 pm)
Permanent Kgdb integration into the kernel - lets get with it., Piet Delaney, (Thu Mar 8, 6:24 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Randy Dunlap, (Tue Apr 17, 2:30 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Piet Delaney, (Fri Apr 20, 6:51 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Andrew Morton, (Fri Apr 20, 7:34 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Andi Kleen, (Sat Apr 21, 5:48 am)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Piet Delaney, (Tue Apr 24, 12:02 am)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Andi Kleen, (Tue Apr 17, 2:45 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Robin Holt, (Fri Apr 20, 12:20 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Sergei Shtylyov, (Tue Apr 17, 2:37 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Randy Dunlap, (Tue Apr 17, 2:42 pm)
Re: Permanent Kgdb integration into the kernel - lets get wi..., Sergei Shtylyov, (Tue Apr 17, 2:45 pm)