Re: [PATCH] x86_64 irq: keep consistent for changing IRQ0_VECTOR from 0x20 to 0x30

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Yinghai Lu <yinghai.lu@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Ingo Molnar <mingo@...>, Andi Kleen <ak@...>
Date: Wednesday, March 7, 2007 - 2:13 pm

Linus Torvalds <torvalds@linux-foundation.org> writes:


This patch will probably work but I'm against it, as is.

The comment fixes or some variation on them are needed.

But code that assumes we place IRQ0 at a particular place isn't
exactly bad but it is brittle.  If we are to reduce our array size
we can also shave a lot of entries off the top because we mostly use
the high end of the vector range for IPI's.

So if we were to introduce some set of defines of exactly which
vectors we can use and do a thorough job of this I think there may
be something reasonable we can do here.

Unless this makes the code clearer I don't think there is much point
in reducing a fixed sized array from 224 entries to 191 entries, and
it has the potential to make this much less pleasant if we goof up
elsewhere.

Eric
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] x86_64 irq: keep consistent for changing IRQ0_VE..., Eric W. Biederman, (Wed Mar 7, 2:13 pm)
Re: [PATCH] x86_64 irq: keep consistent for changing IRQ0_VE..., Eric W. Biederman, (Thu Mar 29, 1:10 am)