Re: 2.6.21-rc suspend regression: sysfs deadlock

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Oliver Neukum <oliver@...>
Cc: Dmitry Torokhov <dmitry.torokhov@...>, Hugh Dickins <hugh@...>, Oliver Neukum <oliver@...>, Maneesh Soni <maneesh@...>, Greg Kroah-Hartman <gregkh@...>, Adrian Bunk <bunk@...>, <linux-kernel@...>
Date: Wednesday, March 7, 2007 - 2:02 pm

On Wed, 7 Mar 2007, Oliver Neukum wrote:

So you just pointed to *another* data structure that apparently violates 
the "you MUST use refcounting" rule.

What is it with you people? It's really simple. Data structures must be 
refcounted if you can reach them two different ways.

If you don't use refcounting, then you'd better make sure that the data 
can be reached only one way (for example, by *not* exposing it for sysfs).

It really *is* that simple. Read the CodingStyle rules.

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.21-rc suspend regression: sysfs deadlock, Hugh Dickins, (Tue Mar 6, 3:20 pm)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Linus Torvalds, (Tue Mar 6, 9:56 pm)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Dmitry Torokhov, (Wed Mar 7, 11:56 am)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Linus Torvalds, (Wed Mar 7, 12:52 pm)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Oliver Neukum, (Wed Mar 7, 12:59 pm)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Linus Torvalds, (Wed Mar 7, 2:02 pm)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Oliver Neukum, (Wed Mar 7, 2:16 pm)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Oliver Neukum, (Wed Mar 7, 10:38 am)
Re: 2.6.21-rc suspend regression: sysfs deadlock, Oliver Neukum, (Tue Mar 6, 4:16 pm)