Home » Mailing list archives » linux-kernel » 2007 » March » 7

[GFS2] Fix bz 229873, alternate test: assertion "!ip->i_inode.i_mapping->nrpages" failed [12/12]

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Steven Whitehouse <swhiteho@...>
To: <cluster-devel@...>
Cc: Abhijith Das <adas@...>, <linux-kernel@...>
Subject: [GFS2] Fix bz 229873, alternate test: assertion "!ip-&gt;i_inode.i_mapping-&gt;nrpages" failed [12/12]
Date: Wednesday, March 7, 2007 - 10:34 am

>From c3f49bc209b28d2b5f82b78baaa827eb3a4d1891 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 7 Mar 2007 09:06:48 +0000
Subject: [PATCH] [GFS2] Fix bz 229873, alternate test: assertion "!ip->i_inode.i_mapping->nrpages" failed

The following removes an incorrect assertion from the GFS2 glops code. This
fixes Red Hat bz 229873. Thanks to Abhijith Das for testing the patch
and confirming the fix.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: Abhijith Das <adas@redhat.com>

diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 4221110..39c8ae2 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -245,7 +245,6 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags)
 
 	if (ip && S_ISREG(ip->i_inode.i_mode)) {
 		truncate_inode_pages(ip->i_inode.i_mapping, 0);
-		gfs2_assert_withdraw(GFS2_SB(&ip->i_inode), !ip->i_inode.i_mapping->nrpages);
 		clear_bit(GIF_PAGED, &ip->i_flags);
 	}
 }
-- 
1.4.4.2



-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GFS2/DLM] Bug fixes [0/12], Steven Whitehouse, (Wed Mar 7, 10:25 am)
[GFS2/DLM] Pull request, Steven Whitehouse, (Wed Mar 7, 10:43 am)
[GFS2] build fix [11/12], Steven Whitehouse, (Wed Mar 7, 10:33 am)
[GFS2] Fix bz 229873, alternate test: assertion "!ip->i_i..., Steven Whitehouse, (Wed Mar 7, 10:34 am)
[GFS2] go_drop_bh is never used, so remove it [10/12], Steven Whitehouse, (Wed Mar 7, 10:32 am)
[GFS2] Remove unused variable [9/12], Steven Whitehouse, (Wed Mar 7, 10:32 am)
[DLM] fs/dlm/user.c should #include "user.h" [5/12], Steven Whitehouse, (Wed Mar 7, 10:29 am)
[GFS2] Fix bz 229831, lookup returns wrong inode [8/12], Steven Whitehouse, (Wed Mar 7, 10:31 am)
[GFS2] Fix bz 230143, incorrect flushing of rgrps [7/12], Steven Whitehouse, (Wed Mar 7, 10:31 am)
[GFS2] pass formal ino in do_filldir_main [6/12], Steven Whitehouse, (Wed Mar 7, 10:30 am)
[GFS2] NFS filehandle check [3/12], Steven Whitehouse, (Wed Mar 7, 10:27 am)
[GFS2] fix hangup when multiple processes are trying to writ..., Steven Whitehouse, (Wed Mar 7, 10:28 am)
[GFS2] fix locking mistake [1/12], Steven Whitehouse, (Wed Mar 7, 10:26 am)
[GFS2] add newline to printk message [2/12], Steven Whitehouse, (Wed Mar 7, 10:27 am)