Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear) | KernelTrap

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Peter Zijlstra <a.p.zijlstra@...>

To: Andrew Morton <akpm@...>

Cc: Miklos Szeredi <miklos@...>, <mingo@...>, <npiggin@...>, <linux-mm@...>, <linux-kernel@...>, <benh@...>

Subject: Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

Date: Wednesday, March 7, 2007 - 5:32 am

On Wed, 2007-03-07 at 01:07 -0800, Andrew Morton wrote:
quoted text> On Wed, 07 Mar 2007 09:51:57 +0100 Miklos Szeredi <miklos@szeredi.hu> wrote:
> 
> > > > Dirty page accounting doesn't work either on
> > > > non-linear mappings
> > > 
> > > It doesn't?  Confused - these things don't have anything to do with each
> > > other do they?
> > 
> > Look in page_mkclean().  Where does it handle non-linear mappings?
> > 
> 
> OK, I'd forgotten about that.  It won't break dirty memory accounting,
> but it'll potentially break dirty memory balancing.
> 
> If we have the wrong page (due to nonlinear), page_check_address() will
> fail and we'll leave the pte dirty.  That puts us back to the pre-2.6.17
> algorithms and I guess it'll break the msync guarantees.
> 
> Peter, I thought we went through the nonlinear problem ages ago and decided
> it was OK?

Can recollect as much, I modelled it after page_referenced() and can't
find any VM_NONLINEAR specific code in there either.

Will have a hard look, but if its broken, then page_referenced if
equally broken it seems, which would make page reclaim funny in the
light of nonlinear mappings.

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 0/6] fault vs truncate/invalidate race fix, Nick Piggin, (Wed Feb 21, 12:49 am)

Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Tue Feb 27, 12:36 am)

Re: [patch 0/6] fault vs truncate/invalidate race fix, Andrew Morton, (Tue Feb 27, 1:32 am)

Re: [patch 0/6] fault vs truncate/invalidate race fix, Nick Piggin, (Tue Feb 27, 4:50 am)

Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Tue Feb 27, 2:26 am)

Re: [patch 0/6] fault vs truncate/invalidate race fix, Benjamin Herrenschmidt, (Tue Feb 27, 2:54 am)

Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Sun Mar 18, 7:13 pm)

[patch 4/6] mm: merge populate and nopage into fault (fixes ..., Nick Piggin, (Wed Feb 21, 12:50 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 2:51 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Benjamin Herrenschmidt, (Wed Mar 7, 6:05 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:17 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Benjamin Herrenschmidt, (Wed Mar 7, 6:46 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 3:19 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 3:08 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 4:19 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 4:27 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 4:59 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 5:22 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:52 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:32 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 5:35 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:50 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:11 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 4:38 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 4:47 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 4:51 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 5:07 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 5:32 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:45 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:04 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 6:06 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 6:13 am)

[rfc][patch 7/6] mm: merge page_mkwrite, Nick Piggin, (Wed Mar 7, 6:30 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:21 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 6:24 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:38 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 6:47 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 7:00 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 8:22 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 8:36 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 7:48 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 8:17 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 8:41 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 9:08 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 9:19 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 9:36 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 9:53 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 10:50 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 9:52 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Jeff Dike, (Wed Mar 7, 11:10 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 10:34 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 11:01 am)

[RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 12:58 pm)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 7:21 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Nick Piggin, (Thu Mar 8, 7:58 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 8:09 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Thu Mar 8, 7:37 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 7:48 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Thu Mar 8, 8:11 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Nick Piggin, (Thu Mar 8, 8:19 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 8:25 am)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Linus Torvalds, (Wed Mar 7, 2:00 pm)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 2:12 pm)

Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 2:24 pm)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 9:56 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 5:25 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:18 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 5:26 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:38 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 5:28 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 4:35 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:29 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 5:39 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 6:09 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 4:53 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:28 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:44 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Thu Mar 8, 8:39 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:49 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:02 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Mon Mar 12, 7:01 pm)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Mon Mar 12, 9:19 pm)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Sat Mar 17, 8:17 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Sat Mar 17, 10:50 pm)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Mon Mar 19, 4:44 pm)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Tue Mar 20, 2:00 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Wed Mar 21, 3:45 pm)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Mon Mar 19, 8:04 am)

Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Jeff Dike, (Sun Mar 18, 9:09 am)

[patch 6/6] mm: remove legacy cruft, Nick Piggin, (Wed Feb 21, 12:50 am)

[patch 5/6] mm: merge nopfn into fault, Nick Piggin, (Wed Feb 21, 12:50 am)

Re: [patch 5/6] mm: merge nopfn into fault, Nick Piggin, (Wed Feb 21, 1:13 am)

[patch 3/6] mm: fix fault vs invalidate race for linear mapp..., Nick Piggin, (Wed Feb 21, 12:50 am)

Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Andrew Morton, (Wed Mar 7, 2:36 am)

Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Nick Piggin, (Wed Mar 7, 2:57 am)

Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Andrew Morton, (Wed Mar 7, 3:08 am)

Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Nick Piggin, (Wed Mar 7, 3:25 am)

[patch 2/6] mm: simplify filemap_nopage, Nick Piggin, (Wed Feb 21, 12:49 am)

[patch 1/6] mm: debug check for the fault vs invalidate race, Nick Piggin, (Wed Feb 21, 12:49 am)

Navigation

Popular discussions


linux-kernel:
Bart Van Assche	Re: Integration of SCST in the mainstream Linux kernel
Greg KH	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Andrew Morton	Re: -mm merge plans for 2.6.23 -- sys_fallocate
git:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
David Miller	[GIT]: Networking
Radu Rendec	htb parallelism on multi-core platforms
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 2 users and 559 guests online.

Online users

Syndicate