On Tue, 2007-03-06 at 22:19 -0700, Eric W. Biederman wrote:
quoted text
> Michael Ellerman <michael@ellerman.id.au> writes:
>=20
> >
> > Hi Eric, comments below ..
> >
> >
> > I get the reasoning for disabling MSI before we start writing back the
> > config space, but don't we want to re-enable MSI on the way out?
>=20
> We are restoring the entire msi flags register which includes the enable =
bit,
quoted text
> setting it a second time is gratuitous.
>=20
> In addition if we are restoring the register when the enable bit is not s=
et.
quoted text
> (because we don't have a mask bit) enabling the msi state is actually
> the wrong thing to do.    But I admit that case can only happen after
> the additions in my last patch.

Yeah, duh.

cheers

--=20
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person