Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Linux Memory Management <linux-mm@...>, Linux Kernel <linux-kernel@...>, Benjamin Herrenschmidt <benh@...>, Ingo Molnar <mingo@...>
Date: Wednesday, March 7, 2007 - 4:19 am

On Wed, Mar 07, 2007 at 08:08:53AM +0100, Nick Piggin wrote:

If it doesn't look very impressive, it could be because it leaves all
the old crud around for backwards compatibility (the worst offenders
are removed in patch 6/6).

If you look at the patchset as a whole, it removes about 250 lines,
mostly of (non trivial) duplicated code in filemap.c memory.c shmem.c
fremap.c, that is nonlinear pages specific and doesn't get anywhere
near the testing that the linear fault path does.

A minimal fix for nonlinear pages would have required changing all
->populate handlers, which I simply thought was not very productive
considering the testing and coverage issues, and that I was going to
rewrite the nonlinear path anyway.

If you like, you can consider patches 1,2,3 as the fix, and ignore
nonlinear (hey, it doesn't even bother checking truncate_count today!).

Then 4,5,6 is the fault/nonlinear rewrite, take it or leave it. I thought
you would have liked the patches...

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 0/6] fault vs truncate/invalidate race fix, Nick Piggin, (Wed Feb 21, 12:49 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Tue Feb 27, 12:36 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Andrew Morton, (Tue Feb 27, 1:32 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Nick Piggin, (Tue Feb 27, 4:50 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Tue Feb 27, 2:26 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Benjamin Herrenschmidt, (Tue Feb 27, 2:54 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Sun Mar 18, 7:13 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Benjamin Herrenschmidt, (Wed Mar 7, 6:05 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Benjamin Herrenschmidt, (Wed Mar 7, 6:46 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 4:19 am)
[rfc][patch 7/6] mm: merge page_mkwrite, Nick Piggin, (Wed Mar 7, 6:30 am)
[RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 12:58 pm)
[patch 6/6] mm: remove legacy cruft, Nick Piggin, (Wed Feb 21, 12:50 am)
[patch 5/6] mm: merge nopfn into fault, Nick Piggin, (Wed Feb 21, 12:50 am)
Re: [patch 5/6] mm: merge nopfn into fault, Nick Piggin, (Wed Feb 21, 1:13 am)
[patch 2/6] mm: simplify filemap_nopage, Nick Piggin, (Wed Feb 21, 12:49 am)