login
Header Space

 
 

Re: [PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Thomas Gleixner <tglx@...>
Cc: Ingo Molnar <mingo@...>, Michael S. Tsirkin <mst@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>, Michal Piotrowski <michal.k.k.piotrowski@...>, Emil Karlson <jkarlson@...>, Soeren Sonnenburg <kernel@...>, Len Brown <lenb@...>
Date: Tuesday, March 6, 2007 - 1:41 pm

On Tue, 6 Mar 2007, Thomas Gleixner wrote:

Well, I already applied the original one that came through Andrew, so I 
really just wanted to note the coding style in general, and your fixed 
patch no longer applied ;)

Also, you do end up testing for "not error" with a


which I guess is ok, if only because we simply don't care about what the 
exact error was. But it means that this particular code sequence ends up 
having the same problem (which is still fewer places than the original 
patch, so we're good).

I personally hate the

	if (hrtimer_switch_to_hres() == SUCCESS)
		return;

kind of syntax (it's just too long, and it's *not* obvious at all that 
SUCCESS is zero and that this is a "negative error or zero" kind of 
function, so it's actually *worse* than just doing what you did, but some 
projects seem to have that kind of approach.

We could encourage people to do

	if (hrtimer_switch_to_hres() >= 0)
		return;

which is fairly obviously a "success" case for a negative error value, but 
I'm not sure the extra typing really is worth it. Does anybody have any 
smart ideas that people might even be ok with following (just making 
things more cumbersome is anti-productive, so I don't want to have some 
stupid rule that everybody really hates)?

			Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.21-rc2, Linus Torvalds, (Wed Feb 28, 1:16 am)
Re: Linux 2.6.21-rc2, David Brown, (Wed Feb 28, 3:23 am)
Re: Linux 2.6.21-rc2, Damien Wyart, (Wed Feb 28, 3:59 am)
Re: Linux 2.6.21-rc2, Brice Goglin, (Wed Feb 28, 3:39 am)
Re: Linux 2.6.21-rc2, Eric W. Biederman, (Wed Feb 28, 9:09 am)
Re: Linux 2.6.21-rc2, David Brown, (Wed Feb 28, 12:44 pm)
Re: Linux 2.6.21-rc2, Randy Dunlap, (Wed Feb 28, 1:07 pm)
Re: Linux 2.6.21-rc2, Gabriel C, (Wed Feb 28, 1:50 am)
[6/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 9:50 pm)
Re: [6/6] 2.6.21-rc2: known regressions, Greg KH, (Sun Mar 4, 11:32 pm)
Re: [6/6] 2.6.21-rc2: known regressions, David Miller, (Sun Mar 4, 10:07 pm)
Re: [6/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 10:26 pm)
Re: [6/6] 2.6.21-rc2: known regressions, David Miller, (Mon Mar 5, 12:42 am)
Re: [6/6] 2.6.21-rc2: known regressions, David Miller, (Sun Mar 4, 10:29 pm)
[5/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 9:50 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Mon Mar 5, 3:57 am)
Re: [5/6] 2.6.21-rc2: known regressions, Bill Davidsen, (Mon Mar 5, 12:14 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Mon Mar 5, 12:21 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Mon Mar 5, 7:12 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Andrew Morton, (Mon Mar 5, 4:13 am)
Re: [5/6] 2.6.21-rc2: known regressions, Daniel Walker, (Mon Mar 5, 11:25 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Mon Mar 5, 11:27 am)
Re: [5/6] 2.6.21-rc2: known regressions, Daniel Walker, (Mon Mar 5, 12:42 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Mon Mar 5, 3:30 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Thomas Gleixner, (Mon Mar 5, 7:43 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Mon Mar 5, 7:45 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Mon Mar 5, 8:38 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Thomas Gleixner, (Mon Mar 5, 9:02 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Mon Mar 5, 9:31 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Mon Mar 5, 10:18 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Tue Mar 6, 6:33 am)
Re: [5/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Tue Mar 6, 6:33 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 6:37 am)
Re: [5/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Tue Mar 6, 6:46 am)
Re: [5/6] 2.6.21-rc2: known regressions, Pavel Machek, (Sun Mar 11, 1:32 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 7:32 am)
Re: [5/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Tue Mar 6, 12:44 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Randy Dunlap, (Fri Mar 16, 11:18 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 1:05 pm)
Re: [PATCH] highres: do not run the TIMER_SOFTIRQ after swit..., Linus Torvalds, (Tue Mar 6, 1:41 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Tue Mar 6, 8:20 am)
Re: [5/6] 2.6.21-rc2: known regressions, Soeren Sonnenburg, (Tue Mar 6, 7:36 am)
Re: [5/6] 2.6.21-rc2: known regressions, Jeff Chua, (Tue Mar 6, 8:09 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 8:07 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 8:51 am)
Re: [5/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Tue Mar 6, 8:55 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 9:03 am)
Re: [5/6] 2.6.21-rc2: known regressions, Thomas Gleixner, (Tue Mar 6, 9:09 am)
Re: [5/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Tue Mar 6, 8:15 am)
Re: [5/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Tue Mar 6, 3:25 am)
Re: [5/6] 2.6.21-rc2: known regressions, Thomas Gleixner, (Tue Mar 6, 4:09 am)
Re: [5/6] 2.6.21-rc2: known regressions, Thomas Gleixner, (Mon Mar 5, 8:25 pm)
Re: [5/6] 2.6.21-rc2: known regressions, Soeren Sonnenburg, (Tue Mar 6, 2:49 am)
Re: [5/6] 2.6.21-rc2: known regressions, Soeren Sonnenburg, (Tue Mar 6, 3:49 am)
[4/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 9:50 pm)
Re: [4/6] 2.6.21-rc2: known regressions, Richard Purdie, (Mon Mar 5, 8:21 am)
Re: [4/6] 2.6.21-rc2: known regressions, Antonino A. Daplas, (Mon Mar 5, 6:35 am)
Re: [4/6] 2.6.21-rc2: known regressions, Andrew, (Mon Mar 5, 11:06 am)
Re: [4/6] 2.6.21-rc2: known regressions, Len Brown, (Thu Mar 8, 7:28 pm)
Re: [4/6] 2.6.21-rc2: known regressions, Andrew, (Fri Mar 9, 3:25 pm)
[3/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 9:50 pm)
Re: [3/6] 2.6.21-rc2: known regressions, Jeff Garzik, (Wed Mar 7, 7:12 am)
Re: [3/6] 2.6.21-rc2: known regressions, Mathieu Bérard, (Fri Mar 9, 9:09 pm)
Re: [3/6] 2.6.21-rc2: known regressions, Tejun Heo, (Mon Mar 12, 7:37 am)
Re: [3/6] 2.6.21-rc2: known regressions, Mathieu Bérard, (Tue Mar 13, 8:31 am)
and try remove another quirk on this computers Re: [3/6] 2.6..., Sergio Monteiro Basto, (Sat Mar 10, 12:11 am)
Re: and try remove another quirk on this computers Re: [3/6]..., Sergio Monteiro Basto, (Sun Mar 11, 12:32 am)
Re: [3/6] 2.6.21-rc2: known regressions, Alan Cox, (Tue Mar 6, 1:08 pm)
Re: [3/6] 2.6.21-rc2: known regressions, Michal Jaegermann, (Sun Mar 4, 11:58 pm)
[2/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 9:50 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Jeff Garzik, (Wed Mar 7, 7:09 am)
Re: [2/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Wed Mar 7, 12:10 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ash Milsted, (Thu Mar 8, 8:03 am)
Re: [2/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Thu Mar 8, 8:31 am)
Re: [2/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Thu Mar 8, 2:01 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Thu Mar 8, 3:57 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Thu Mar 8, 3:46 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 3:25 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 7:07 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Thu Mar 8, 7:49 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Johannes Stezenbach, (Fri Mar 9, 1:48 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Pavel Machek, (Fri Mar 9, 7:35 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Sat Mar 10, 5:01 am)
s2ram (was Re: [2/6] 2.6.21-rc2: known regressions), Pavel Machek, (Sat Mar 10, 6:04 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Stefan Seyfried, (Sat Mar 10, 7:43 am)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Sat Mar 10, 11:18 am)
Re: [2/6] 2.6.21-rc2: known regressions, Pavel Machek, (Sat Mar 10, 6:08 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Sun Mar 11, 4:20 am)
Re: [2/6] 2.6.21-rc2: known regressions, Stefan Seyfried, (Mon Mar 12, 2:34 am)
Re: [2/6] 2.6.21-rc2: known regressions, Johannes Stezenbach, (Sat Mar 10, 9:53 am)
Re: [2/6] 2.6.21-rc2: known regressions, Pavel Machek, (Fri Mar 9, 7:19 am)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Sun Mar 18, 12:07 pm)
Re: [linux-pm] [2/6] 2.6.21-rc2: known regressions, Jim Gettys, (Sun Mar 18, 12:40 pm)
Re: [linux-pm] [2/6] 2.6.21-rc2: known regressions, Bill Davidsen, (Mon Mar 19, 4:33 pm)
Re: [linux-pm] [2/6] 2.6.21-rc2: known regressions, Jim Gettys, (Mon Mar 19, 6:08 pm)
Re: [linux-pm] [2/6] 2.6.21-rc2: known regressions, Bill Davidsen, (Tue Mar 20, 10:44 am)
BSOD (was: [2/6] 2.6.21-rc2: known regressions), Pete Zaitcev, (Mon Mar 19, 3:08 pm)
Re: BSOD, David Miller, (Mon Mar 19, 3:38 pm)
Re: BSOD, Jesse Barnes, (Mon Mar 19, 3:54 pm)
Re: BSOD, David Miller, (Mon Mar 19, 4:05 pm)
Re: BSOD, Paul Mackerras, (Tue Mar 20, 5:19 am)
Re: BSOD, Jim Gettys, (Tue Mar 20, 4:33 pm)
Re: BSOD, Jim Gettys, (Mon Mar 19, 4:20 pm)
Re: BSOD, Jesse Barnes, (Mon Mar 19, 4:20 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Fri Mar 9, 6:56 am)
Re: [2/6] 2.6.21-rc2: known regressions, Linus Torvalds, (Fri Mar 9, 2:00 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 7:12 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 7:28 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 3:06 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Michael S. Tsirkin, (Thu Mar 8, 3:47 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 4:10 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Ingo Molnar, (Thu Mar 8, 3:10 pm)
Re: [2/6] 2.6.21-rc2: known regressions, Jeff Chua, (Thu Mar 8, 11:11 am)
[1/6] 2.6.21-rc2: known regressions, Adrian Bunk, (Sun Mar 4, 9:50 pm)
Re: [1/6] 2.6.21-rc2: known regressions, Jeff Garzik, (Wed Mar 7, 7:06 am)
Re: [1/6] 2.6.21-rc2: known regressions, Albert Hopkins, (Wed Mar 7, 6:17 pm)
[BUG} usb regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 5, 12:34 am)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 10:56 am)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Oliver Neukum, (Mon Mar 12, 11:06 am)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 11:13 am)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Oliver Neukum, (Mon Mar 12, 11:27 am)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 12:03 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 12:11 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 12:14 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 12:27 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 12:50 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Oliver Neukum, (Mon Mar 12, 2:48 pm)
[PATCH] usb-serial regression (Oops) in 2.6.21-rc*, Mark Lord, (Mon Mar 12, 4:22 pm)
Re: [PATCH] usb-serial regression (Oops) in 2.6.21-rc*, Jim Radford, (Mon Mar 12, 6:42 pm)
[PATCH] usb-serial regression fix, Jim Radford, (Mon Mar 12, 6:59 pm)
Re: [PATCH] usb-serial regression fix, Greg KH, (Mon Mar 12, 8:18 pm)
Re: [PATCH] usb-serial regression fix, Jim Radford, (Mon Mar 12, 8:41 pm)
Re: [PATCH] usb-serial regression fix, Mark Lord, (Mon Mar 12, 9:55 pm)
Re: [PATCH] usb-serial regression fix, Jim Radford, (Tue Mar 13, 5:14 am)
Re: [PATCH] usb-serial regression fix, Mark Lord, (Tue Mar 13, 9:55 am)
Re: [PATCH] usb-serial regression fix, Jim Radford, (Tue Mar 13, 11:30 am)
Re: [PATCH] usb-serial regression fix, Mark Lord, (Tue Mar 13, 12:35 pm)
Re: [PATCH] usb-serial regression fix, Oliver Neukum, (Tue Mar 13, 6:14 am)
Re: [PATCH] usb-serial regression fix, Mark Lord, (Tue Mar 13, 9:39 am)
Re: [PATCH] usb-serial regression fix, Oliver Neukum, (Tue Mar 13, 9:50 am)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Oliver Neukum, (Mon Mar 12, 12:28 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 12, 12:22 pm)
Re: [BUG} usb-serial regression in 2.6.21-rc2-git3, Oliver Neukum, (Mon Mar 12, 11:38 am)
Re: [BUG} usb regression in 2.6.21-rc2-git3, Mark Lord, (Mon Mar 5, 12:43 am)
[BUG] sdhci regression in 2.6.21-rc2, Mark Lord, (Mon Mar 5, 12:37 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Pierre Ossman, (Mon Mar 5, 1:36 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Mark Lord, (Mon Mar 5, 10:25 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Pierre Ossman, (Mon Mar 5, 11:20 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Pierre Ossman, (Mon Mar 5, 11:23 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Mark Lord, (Mon Mar 5, 11:35 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Pierre Ossman, (Mon Mar 5, 12:00 pm)
Re: [BUG] sdhci regression in 2.6.21-rc2, Mark Lord, (Mon Mar 5, 12:18 pm)
Re: [BUG] sdhci regression in 2.6.21-rc2, Mark Lord, (Mon Mar 5, 11:19 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Andrew Morton, (Tue Mar 6, 12:17 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Pierre Ossman, (Tue Mar 6, 1:47 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Andrew Morton, (Tue Mar 6, 2:09 am)
Re: [BUG] sdhci regression in 2.6.21-rc2, Pierre Ossman, (Tue Mar 6, 3:23 am)
Re: [1/6] 2.6.21-rc2: known regressions, Mark Lord, (Mon Mar 5, 12:01 am)
Re: [1/6] 2.6.21-rc2: known regressions, Greg KH, (Mon Mar 5, 12:34 am)
Re: [1/6] 2.6.21-rc2: known regressions, Marcel Holtmann, (Mon Mar 5, 8:42 am)
Re: [1/6] 2.6.21-rc2: known regressions, Greg KH, (Sun Mar 4, 11:35 pm)
Re: [1/6] 2.6.21-rc2: known regressions, Johannes Berg, (Mon Mar 5, 8:55 pm)
Re: [1/6] 2.6.21-rc2: known regressions, Andrew Morton, (Sun Mar 4, 10:26 pm)
[PATCH] affinity is not defined in non-smp kernels - i386, Fernando Luis , (Wed Feb 28, 3:13 am)
Re: [PATCH] affinity is not defined in non-smp kernels - i386, Eric W. Biederman, (Wed Feb 28, 3:24 am)
Re: [PATCH] affinity is not defined in non-smp kernels - i386, Eric W. Biederman, (Wed Feb 28, 2:21 pm)
speck-geostationary