[-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Adrian Bunk
Date: Saturday, March 31, 2007 - 1:55 pm

On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote:


This patch makes the needlessly global PHY_DEVICES[] static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

BTW: Why is the name uppercase?

--- linux-2.6.21-rc5-mm3/drivers/net/qla3xxx.c.old	2007-03-31 21:30:20.000000000 +0200
+++ linux-2.6.21-rc5-mm3/drivers/net/qla3xxx.c	2007-03-31 22:02:00.000000000 +0200
@@ -88,7 +88,7 @@
 	char 		*name;
 } PHY_DEVICE_INFO_t;
 
-const PHY_DEVICE_INFO_t PHY_DEVICES[] =
+static const PHY_DEVICE_INFO_t PHY_DEVICES[] =
 	{{PHY_TYPE_UNKNOWN,    0x000000, 0x0, "PHY_TYPE_UNKNOWN"},
 	 {PHY_VITESSE_VSC8211, 0x0003f1, 0xb, "PHY_VITESSE_VSC8211"},
 	 {PHY_AGERE_ET1011C,   0x00a0bc, 0x1, "PHY_AGERE_ET1011C"},
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.21-rc5-mm3, Andrew Morton, (Fri Mar 30, 1:05 am)
Re: 2.6.21-rc5-mm3, Rafael J. Wysocki, (Fri Mar 30, 4:00 am)
Re: 2.6.21-rc5-mm3, Michal Piotrowski, (Fri Mar 30, 9:31 am)
Re: 2.6.21-rc5-mm3, Dmitry Torokhov, (Fri Mar 30, 9:38 am)
Re: 2.6.21-rc5-mm3, Ingo Molnar, (Fri Mar 30, 9:55 am)
Re: 2.6.21-rc5-mm3, Andrew Morton, (Fri Mar 30, 9:59 am)
Re: 2.6.21-rc5-mm3, Michal Piotrowski, (Fri Mar 30, 10:19 am)
Re: 2.6.21-rc5-mm3, Valdis.Kletnieks, (Fri Mar 30, 10:23 am)
Re: 2.6.21-rc5-mm3, Johannes Berg, (Fri Mar 30, 11:58 am)
2.6.21-rc5-mm3 - cpuidle, acpi, and C-states, Valdis.Kletnieks, (Sat Mar 31, 1:05 am)
2.6.21-rc5-mm3: Why was my vioc cleanup patch dropped?, Adrian Bunk, (Sat Mar 31, 12:25 pm)
[-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static, Adrian Bunk, (Sat Mar 31, 1:55 pm)
Re: [2.6 patch] remove the config option for the cs5530a_w ..., Jeremy Fitzhardinge, (Sat Mar 31, 2:05 pm)
Re: [2.6 patch] remove the config option for the cs5530a_w ..., Jeremy Fitzhardinge, (Sat Mar 31, 2:17 pm)
Re: 2.6.21-rc5-mm3 - no boot, &quot;address not 2M aligned&quot;, Eric W. Biederman, (Sat Mar 31, 11:15 pm)
Re: 2.6.21-rc5-mm3, Michal Piotrowski, (Sun Apr 1, 9:00 am)
Re: 2.6.21-rc5-mm3, Andrew Morton, (Sun Apr 1, 12:03 pm)
Re: 2.6.21-rc5-mm3, Rafael J. Wysocki, (Sun Apr 1, 1:39 pm)
Re: 2.6.21-rc5-mm3, Rafael J. Wysocki, (Sun Apr 1, 1:56 pm)
Re: 2.6.21-rc5-mm3, Rafael J. Wysocki, (Sun Apr 1, 2:59 pm)
[PATCH 1/2] x86_64: Reflect the relocatability of the kern ..., Eric W. Biederman, (Sun Apr 22, 10:12 pm)
[PATCH 2/2] x86_64: Remove CONFIG_PHYSICAL_START and CONFI ..., Eric W. Biederman, (Sun Apr 22, 10:15 pm)
Re: [PATCH 2/2] x86_64: Remove CONFIG_PHYSICAL_START and C ..., Eric W. Biederman, (Sun Apr 22, 11:17 pm)
Re: [PATCH 1/2] x86_64: Reflect the relocatability of the ..., Eric W. Biederman, (Tue Apr 24, 12:21 am)