login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
March
»
31
Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Tejun Heo
Subject:
Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
Date: Friday, March 30, 2007 - 8:36 pm
Mark Lord wrote:
quoted text
> Ideally, this would go into linux-2.6.21. > > Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK. > > Signed-off-by: Mark Lord <mlord@pobox.com> > --- > --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21 > 13:35:02.000000000 -0400 > +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400 > @@ -333,7 +333,7 @@ > scsi_cmd[8] = args[3]; > scsi_cmd[10] = args[4]; > scsi_cmd[12] = args[5]; > - scsi_cmd[13] = args[6] & 0x0f; > + scsi_cmd[13] = args[6] & 0x4f; > scsi_cmd[14] = args[0]; > > /* Good values for timeout and retries? Values below
IDE seems to be just overriding devsel (0x10) and leaving the rest alone. Maybe we should do (args[6] & ~0x10) here? Or is it safer this way? Thanks. -- tejun -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[patch 00/37] 2.6.20-stable review
, Greg KH
, (Fri Mar 30, 2:03 pm)
[patch 01/37] ide: clear bmdma status in ide_intr() for IC ...
, Greg KH
, (Fri Mar 30, 2:03 pm)
[patch 02/37] ide: remove clearing bmdma status from cdrom ...
, Greg KH
, (Fri Mar 30, 2:03 pm)
[patch 03/37] sata_nv: delay on switching between NCQ and ...
, Greg KH
, (Fri Mar 30, 2:03 pm)
[patch 04/37] UML - fix epoll
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 05/37] UML - host VDSO fix
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 06/37] UML - Fix static linking
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 06/37] UML - Fix static linking
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 07/37] UML - use correct register file size everywhere
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 08/37] uml: fix unreasonably long udelay
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 09/37] ieee1394: dv1394: fix CardBus card ejection
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 10/37] NET: Fix packet classidier NULL pointer OOPS
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 11/37] NET_SCHED: Fix ingress qdisc locking.
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 12/37] IPV6: Fix ipv6 round-robin locking.
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 13/37] PPP: Fix PPP skb leak
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 14/37] DCCP: Fix exploitable hole in DCCP socket op ...
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 15/37] VIDEO: Fix FFB DAC revision probing
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 16/37] NET: Fix sock_attach_fd() failure in sys_acc ...
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 16/37] NET: Fix sock_attach_fd() failure in sys_acc ...
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 17/37] SPARC: Fix sparc builds with gcc-4.2.x
, Greg KH
, (Fri Mar 30, 2:04 pm)
[patch 18/37] Fix decnet endianness
, Greg KH
, (Fri Mar 30, 2:05 pm)
[patch 19/37] NET: Fix FIB rules compatability
, Greg KH
, (Fri Mar 30, 2:05 pm)
[patch 20/37] DVB: fix nxt200x rf input switching
, Greg KH
, (Fri Mar 30, 2:05 pm)
[patch 21/37] V4L: radio: Fix error in Kbuild file
, Greg KH
, (Fri Mar 30, 2:05 pm)
[patch 22/37] V4L: Fix SECAM handling on saa7115
, Greg KH
, (Fri Mar 30, 2:05 pm)
[patch 23/37] V4L: msp_attach must return 0 if no msp3400 ...
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 24/37] DVB: isl6421: dont reference freed memory
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 25/37] dvb-core: fix several locking related problems
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 26/37] V4L: saa7146: Fix allocation of clipping memory
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 27/37] jmicron: make ide jmicron driver play nice w ...
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 28/37] i2o: block IO errors on i2o disk
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 29/37] ide: revert "ide: fix drive side 80c cable c ...
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 30/37] CIFS: Allow reset of file to ATTR_NORMAL whe ...
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 31/37] CIFS: reset mode when client notices that AT ...
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails ...
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 33/37] libata: clear TF before IDENTIFYing
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 34/37] libata bugfix: HDIO_DRIVE_TASK
, Greg KH
, (Fri Mar 30, 2:06 pm)
[patch 35/37] libata: sata_mv: dont touch reserved bits in ...
, Greg KH
, (Fri Mar 30, 2:07 pm)
[patch 36/37] libata: sata_mv: Fix 50xx irq mask
, Greg KH
, (Fri Mar 30, 2:07 pm)
[patch 37/37] generic_serial: fix decoding of baud rate
, Greg KH
, (Fri Mar 30, 2:07 pm)
Re: [patch 00/37] 2.6.20-stable review
, Greg KH
, (Fri Mar 30, 2:10 pm)
Re: [patch 34/37] libata bugfix: HDIO_DRIVE_TASK
, Mark Lord
, (Fri Mar 30, 2:42 pm)
libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
, Mark Lord
, (Fri Mar 30, 2:45 pm)
Re: [uml-devel] [patch 06/37] UML - Fix static linking
, Blaisorblade
, (Fri Mar 30, 6:21 pm)
Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fa ...
, Patrick McHardy
, (Fri Mar 30, 6:41 pm)
Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fa ...
, Herbert Xu
, (Fri Mar 30, 7:14 pm)
Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fa ...
, Patrick McHardy
, (Fri Mar 30, 7:31 pm)
Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fa ...
, Greg KH
, (Fri Mar 30, 8:11 pm)
Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
, Tejun Heo
, (Fri Mar 30, 8:36 pm)
Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fa ...
, Herbert Xu
, (Fri Mar 30, 8:45 pm)
Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
, Mark Lord
, (Sat Mar 31, 9:55 am)
Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
, Tejun Heo
, (Sat Mar 31, 10:05 am)
Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fa ...
, J. Bruce Fields
, (Sat Mar 31, 2:35 pm)
Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
, Jeff Garzik
, (Tue Apr 3, 11:08 pm)
Re: [patch 00/37] 2.6.20-stable review
, Chuck Ebbert
, (Wed Apr 4, 7:28 am)
Re: [stable] [patch 00/37] 2.6.20-stable review
, Greg KH
, (Wed Apr 4, 2:23 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar
Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Paul Turner
[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Andi Kleen
Re: - romsignature-checksum-cleanup-2.patch removed from -mm tree
Axel Lin
[PATCH] tc6393xb: fix wrong goto labels for error handling
git
:
Christian Jaeger
Re: Problem with Git.pm bidi_pipe methods
Linus Torvalds
Re: mingw, windows, crlf/lf, and git
Nicolas Pitre
Re: [PATCH 2/2] Implement a simple delta_base cache
Linus Torvalds
[PATCH 1/7] Make unpack_trees_options bit flags actual bitfields
Jeff King
[PATCH 1/4] t4012: use test_cmp instead of cmp
git-commits-head
:
Linux Kernel Mailing List
i2c-i801: Add Intel Cougar Point device IDs
Linux Kernel Mailing List
Staging: batman-adv: splitting /proc vis file into vis_server and vis_data
Linux Kernel Mailing List
drm/i915: Add information on pinning and fencing to the i915 list debug.
Linux Kernel Mailing List
ocfs2: Stop orphan scan as early as possible during umount
Linux Kernel Mailing List
x86, apic: clean up spurious vector sanity check
linux-netdev
:
Richard Cochran
Re: [PATCH v3 3/3] ptp: Added a clock that uses the eTSEC found on the MPC85xx.
Gerrit Renker
v2 [PATCH 1/4] dccp: Limit feature negotiation to connection setup phase
Lennert Buytenhek
Re: [PATCH 3/6] [NET] dsa: add support for original DSA tagging format
Inaky Perez-Gonzalez
[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Pavel Emelyanov
[PATCH net-2.6.26 2/2][NETNS]: The generic per-net pointers.
freebsd-current
:
Boris Samorodov
Re: twa + dump = sbwait
John Baldwin
Re: Possible case of sched_ule never honoring cpu_set affinity?
韓家標 Bill Hacker
Re: ZFS honesty
samira
sata atapi on ich9r
Bjoern A. Zeeb
Re: Can not boot 7.0-BETA3 with IPSEC
Colocation donated by:
Syndicate