login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
March
»
30
Re: [QUESTION] check for mem in slab
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Pekka Enberg
Subject:
Re: [QUESTION] check for mem in slab
Date: Friday, March 30, 2007 - 4:55 am
On 3/30/07, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
quoted text
> > in file mm/slab.c and routine kmem_cache_init() I found there > > is no checking for allocated memory on line: > > > > /* 4) Replace the bootstrap head arrays */ > > { > > struct array_cache *ptr; > > > > ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL); > > > > --> no check for ptr == NULL <-- > [...] > > is that OK? or it's a bug? > > It's ok. If that allocation fails your machine won't come up anyway.
We ought to add a BUG_ON or comment at least there as this keeps popping up again and again. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[QUESTION] check for mem in slab
, Cyrill Gorcunov
, (Thu Mar 29, 9:04 am)
Re: [QUESTION] check for mem in slab
, Heiko Carstens
, (Thu Mar 29, 11:56 pm)
Re: [QUESTION] check for mem in slab
, Pekka Enberg
, (Fri Mar 30, 4:55 am)
Re: [QUESTION] check for mem in slab
, Cyrill Gorcunov
, (Fri Mar 30, 9:41 am)
[PATCH] Catch kmalloc failure in kmem_cache_init() (was: [ ...
, Johannes Weiner
, (Mon Apr 2, 2:50 am)
[PATCH] Catch kmalloc() failure in kmem_cache_init()
, Johannes Weiner
, (Mon Apr 2, 3:18 am)
Re: [PATCH] Catch kmalloc() failure in kmem_cache_init()
, Pekka J Enberg
, (Mon Apr 2, 3:23 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Nick Piggin
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rather than rcu
Kyle Moffett
Re: [PATCH 1/4] stringbuf: A string buffer implementation
Ingo Molnar
Re: [PATCH 00/12] mm/x86: bootmem
Andrew Morton
Re: [patch 1/5] wait: use lock bitops for __wait_on_bit_lock
git
:
Stephen Boyd
Re: [PATCH] Speed up bash completion loading
Jakub Narebski
Re: Avery Pennarun's git-subtree?
Junio C Hamano
Re: [PATCH v2 04/13] Teach rebase interactive the mark command
Catalin Marinas
Re: [ANNOUNCE] Stacked GIT 0.14.2
Eric Wong
[PATCH 5/5] rerere: add the diff command
git-commits-head
:
Linux Kernel Mailing List
[POWERPC] fsl_soc: add support to gianfar for fixed-link property
Linux Kernel Mailing List
fat: fix parse_options()
Linux Kernel Mailing List
ipmi: add oem message handling
Linux Kernel Mailing List
powerpc/85xx/86xx: Fix build w/ CONFIG_PCI=n
Linux Kernel Mailing List
KVM: x86 emulator: during rep emulation decrement ECX only if emulation succeeded
linux-netdev
:
Paweł Staszewski
Re: DCA/IOAT problem
Jarek Poplawski
Re: [PATCH iproute2] Re: HTB accuracy for high speed
Ingo Oeser
Re: [NET-NEXT PATCH 3/3] e1000e: add support for new 82574L part
Rick Jones
Re: UDP path MTU discovery
Dmitry Kozlov
Re: [PATCH v8] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)
openbsd-misc
:
David Vasek
Re: how to undelete?
Gruppo BCC
Banca inviato una notifica che e necessario completare
Pau Amaro-Seoane
Re: First install: Grub doesn't find partitions
Nick Holland
Re: Unattended OpenBSD Installation
stuart van Zee
Re: CVS hosed
Colocation donated by:
Syndicate