> On Wed, Mar 28, 2007 at 03:26:56PM -0700, Chris Wright wrote:
> > BTW, this will interact shared_kernel_pmd patch that Jeremy's posted a
> > few times (I know at least wli has looked over that one). We need to
> > make sure that PAE under at least Xen hypervisor has a page-sized pgd,
> > although the mmlist chaining looks nice to me.
>
> That, not to mention the total lack of verification of the pageattr.c
> code, are among the reasons I didn't want it posted.
>
>
> * Christoph Lameter (
clameter@sgi.com) wrote:
> >> + memcpy(&pgd[USER_PTRS_PER_PGD], &swapper_pg_dir[USER_PTRS_PER_PGD],
> >> + KERNEL_PGD_PTRS*sizeof(pgd_t));
>
> On Wed, Mar 28, 2007 at 03:26:56PM -0700, Chris Wright wrote:
> > clone_pgd_range() for consistency? and it seems we lost a
> > paravirt_alloc_pd_clone() in there somewhere.
>
> Yes, another reason why it shouldn't have been posted as-is. It was not
> intended to for anything more than comparative benchmarking on systems
> without graphics running on the bare metal as opposed to Xen/etc. guests.