[-mm patch] fs/revoke.c: cleanups (and bugfix for 64bit systems)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Pekka Enberg <penberg@...>
Cc: <linux-kernel@...>
Date: Saturday, March 24, 2007 - 9:07 am

On Mon, Mar 19, 2007 at 08:56:23PM -0800, Andrew Morton wrote:


This patch contains the following:
- every file should #include the headers containing the prototypes for
  it's global functions
- fix the wrong return value of sys_frevoke() gcc was now able to detect
- make 2 needlessly global structs static

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 fs/revoke.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--- linux-2.6.21-rc4-mm1/fs/revoke.c.old	2007-03-23 23:31:46.000000000 +0100
+++ linux-2.6.21-rc4-mm1/fs/revoke.c	2007-03-23 23:50:39.000000000 +0100
@@ -16,6 +16,7 @@
 #include <linux/mount.h>
 #include <linux/sched.h>
 #include <linux/revoked_fs_i.h>
+#include <linux/syscalls.h>
 
 /*
  * This is used for pre-allocating an array of file pointers so that we don't
@@ -28,7 +29,7 @@
 	unsigned long restore_start;
 };
 
-struct kmem_cache *revokefs_inode_cache;
+static struct kmem_cache *revokefs_inode_cache;
 
 /*
  * Revoked file descriptors point to inodes in the revokefs filesystem.
@@ -551,7 +552,7 @@
 	return err;
 }
 
-asmlinkage int sys_frevoke(unsigned int fd)
+asmlinkage long sys_frevoke(unsigned int fd)
 {
 	struct file *file = fget(fd);
 	int err = -EBADF;
@@ -618,7 +619,7 @@
 			     REVOKEFS_MAGIC, mnt);
 }
 
-struct file_system_type revokefs_fs_type = {
+static struct file_system_type revokefs_fs_type = {
 	.name = "revokefs",
 	.get_sb = revokefs_get_sb,
 	.kill_sb = kill_anon_super

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.21-rc4-mm1, Andrew Morton, (Tue Mar 20, 12:56 am)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 5:57 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Mon Mar 26, 6:22 pm)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 7:43 pm)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 4:05 pm)
Re: 2.6.21-rc4-mm1, Jean Delvare, (Mon Mar 26, 3:35 pm)
Re: 2.6.21-rc4-mm1, Greg KH, (Mon Mar 26, 7:26 pm)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 3:47 pm)
Re: 2.6.21-rc4-mm1, Paul Mackerras, (Mon Mar 26, 7:29 pm)
[-mm patch] fs/revoke.c: cleanups (and bugfix for 64bit syst..., Adrian Bunk, (Sat Mar 24, 9:07 am)
[-mm patch] unexport bio_{,un}map_user, Adrian Bunk, (Sat Mar 24, 9:07 am)
[-mm patch] lguest: #if 0 check_bug_kill(), Adrian Bunk, (Sat Mar 24, 9:06 am)
Re: [-mm patch] lguest: #if 0 check_bug_kill(), Rusty Russell, (Sun Mar 25, 3:33 am)
[-mm patch] lguest: remove check_bug_kill(), Adrian Bunk, (Sun Mar 25, 10:57 am)
Re: 2.6.21-rc4-mm1, J.A. , (Thu Mar 22, 7:27 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Mon Mar 26, 4:31 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Thu Mar 22, 9:41 pm)
Re: 2.6.21-rc4-mm1, Reuben Farrelly, (Wed Mar 21, 6:14 am)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 9:47 pm)
Re: 2.6.21-rc4-mm1, Greg KH, (Wed Mar 21, 2:36 pm)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 7:49 pm)
FireWire update in -mm (was 2.6.21-rc4-mm1), Stefan Richter, (Tue Mar 20, 7:10 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Tue Mar 20, 5:04 pm)
Re: 2.6.21-rc4-mm1: multiple definition of `queue_pushbutton..., Kristen Carlson Accardi, (Wed Mar 21, 2:45 pm)
[PATCH] utrace: make an inline void, Randy Dunlap, (Tue Mar 20, 2:09 pm)
Re: [PATCH] utrace: make an inline void, Roland McGrath, (Tue Mar 20, 9:48 pm)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 1:31 pm)
Re: 2.6.21-rc4-mm1, Kees Cook, (Tue Mar 20, 3:20 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Wed Mar 21, 1:47 am)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Wed Mar 21, 6:19 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Wed Mar 21, 7:01 pm)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Thu Mar 22, 4:54 am)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Wed Mar 21, 7:59 am)
Re: 2.6.21-rc4-mm1, David Woodhouse, (Thu Mar 22, 5:17 am)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Thu Mar 22, 7:41 am)
Re: 2.6.21-rc4-mm1, David Woodhouse, (Thu Mar 22, 12:25 pm)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Thu Mar 22, 12:28 pm)
Re: 2.6.21-rc4-mm1, David Woodhouse, (Wed Mar 21, 7:25 am)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 4:50 pm)
Re: 2.6.21-rc4-mm1, Stéphane Jourdois, (Tue Mar 20, 4:42 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Tue Mar 20, 12:36 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Tue Mar 20, 8:14 pm)
Re: 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 10:31 am)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Tue Mar 20, 12:09 pm)
Re: 2.6.21-rc4-mm1, Pavel Machek, (Tue Mar 20, 2:38 pm)
Re: 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 3:40 pm)
Re: 2.6.21-rc4-mm1, Rafael J. Wysocki, (Tue Mar 20, 4:12 pm)
Re: 2.6.21-rc4-mm1, Pavel Machek, (Tue Mar 20, 3:56 pm)
Re: 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 4:13 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Pavel Machek, (Tue Mar 20, 4:21 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Rafael J. Wysocki, (Tue Mar 20, 4:58 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 4:58 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Rafael J. Wysocki, (Tue Mar 20, 5:06 pm)
Re: 2.6.21-rc4-mm1 [PATCH] init/missing_syscalls.h fix, Stephane Jourdois, (Tue Mar 20, 6:52 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Tue Mar 20, 5:45 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 4:41 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 5:48 am)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Thu Mar 22, 6:04 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 1:07 pm)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 2:17 pm)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Fri Mar 23, 2:18 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Fri Mar 23, 4:45 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Fri Mar 23, 8:28 am)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Fri Mar 23, 5:45 pm)
debug rsdl 0.33, Con Kolivas, (Fri Mar 23, 7:26 pm)
Re: debug rsdl 0.33, Torsten Kaiser, (Sun Mar 25, 2:28 pm)
Re: debug rsdl 0.33, Con Kolivas, (Sun Mar 25, 6:49 pm)
Re: debug rsdl 0.33, Con Kolivas, (Sun Mar 25, 6:59 pm)
Re: debug rsdl 0.33, Andy Whitcroft, (Mon Mar 26, 3:49 am)
Re: debug rsdl 0.33, Andy Whitcroft, (Mon Mar 26, 11:28 am)
Re: debug rsdl 0.33, Con Kolivas, (Mon Mar 26, 12:12 pm)
Re: debug rsdl 0.33, Andrew Morton, (Sun Mar 25, 6:01 pm)
Re: debug rsdl 0.33, Andy Whitcroft, (Sun Mar 25, 8:27 am)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Thu Mar 22, 6:14 pm)
Re: 2.6.21-rc4-mm1, Michal Piotrowski, (Tue Mar 20, 3:54 am)