Home » Mailing list archives » linux-kernel » 2007 » March » 22

[PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jarek Poplawski
Subject: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock
Date: Wednesday, March 21, 2007 - 11:11 pm

Here is some joke:

[PATCH] lockdep: lockdep_depth vs. debug_locks

lockdep really shouldn't be used when debug_locks == 0!


Reported-by: Folkert van Heusden <folkert@vanheusden.com>
Inspired-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>

---

diff -Nurp 2.6.21-rc4-git4-/include/linux/lockdep.h 2.6.21-rc4-git4/include/linux/lockdep.h
--- 2.6.21-rc4-git4-/include/linux/lockdep.h	2007-03-20 20:24:17.000000000 +0100
+++ 2.6.21-rc4-git4/include/linux/lockdep.h	2007-03-21 22:32:41.000000000 +0100
@@ -245,7 +245,7 @@ extern void lock_release(struct lockdep_
 
 # define INIT_LOCKDEP				.lockdep_recursion = 0,
 
-#define lockdep_depth(tsk)	((tsk)->lockdep_depth)
+#define lockdep_depth(tsk)	(debug_locks ? (tsk)->lockdep_depth : 0)
 
 #else /* !LOCKDEP */
 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [2.6.20] BUG: workqueue leaked lock, Neil Brown, (Sun Mar 18, 11:24 pm)
[PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Jarek Poplawski, (Tue Mar 20, 2:37 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Oleg Nesterov, (Tue Mar 20, 9:07 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Jarek Poplawski, (Wed Mar 21, 1:05 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Oleg Nesterov, (Wed Mar 21, 7:46 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Jarek Poplawski, (Wed Mar 21, 8:16 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Folkert van Heusden, (Wed Mar 21, 8:17 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Oleg Nesterov, (Wed Mar 21, 8:29 am)
Re: [PATCH] Re: [2.6.20] BUG: workqueue leaked lock, Oleg Nesterov, (Wed Mar 21, 11:16 am)
[PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20 ..., Jarek Poplawski, (Wed Mar 21, 11:11 pm)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Andrew Morton, (Wed Mar 21, 11:28 pm)
[PATCH] lockdep: debug_show_all_locks &amp; debug_show_held_l ..., Jarek Poplawski, (Wed Mar 21, 11:57 pm)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Jarek Poplawski, (Thu Mar 22, 12:06 am)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Jarek Poplawski, (Thu Mar 22, 12:13 am)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Peter Zijlstra, (Thu Mar 22, 12:22 am)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Jarek Poplawski, (Thu Mar 22, 12:23 am)
Re: [PATCH] lockdep: debug_show_all_locks &amp; debug_show_he ..., Peter Zijlstra, (Thu Mar 22, 12:23 am)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Jarek Poplawski, (Thu Mar 22, 1:26 am)
Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2. ..., Ingo Molnar, (Thu Mar 22, 2:06 am)
Re: [PATCH] lockdep: debug_show_all_locks &amp; debug_show_he ..., Ingo Molnar, (Thu Mar 22, 2:06 am)