login
Header Space

 
 

Re: 2.6.21-rc4-mm1 [PATCH] init/missing_syscalls.h fix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, David Woodhouse <dwmw2@...>
Date: Tuesday, March 20, 2007 - 6:52 am

On Mon, Mar 19, 2007 at 08:56:23PM -0800, Andrew Morton wrote:

[..]



Hi,

I needed the following patch to fix this compile error (which does not
happend at first compile):

kwisatz@ambre:/usr/src/linux-2.6.21-rc4-mm1 $ rm init/missing_syscalls.h 
kwisatz@ambre:/usr/src/linux-2.6.21-rc4-mm1 $ make init
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CHK     include/linux/compile.h
  GEN     init/missing_syscalls.h
  CC      init/missing_syscalls.o
  LD      init/built-in.o
kwisatz@ambre:/usr/src/linux-2.6.21-rc4-mm1 $ cat init/.missing_syscalls.h.cmd
cmd_init/missing_syscalls.h := sed -n '/^\#define/s/[^_]*__NR_\([^[:space:]]*\).*/ \#if !defined (__NR_) \&\& !defined (__IGNORE_)
 \#warning syscall  not implemented
 \#endif/p' /usr/src/linux-2.6.21-rc4-mm1/include/asm-i386/unistd.h >init/missing_syscalls.h

# (note all three \1 missing, replaced by char '^A', not visible here.
# note also that my /bin/sh is symlinked to dash (not bash) 0.5.3

kwisatz@ambre:/usr/src/linux-2.6.21-rc4-mm1 $ make init
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
init/.missing_syscalls.h.cmd:2: *** séparateur manquant . Arrêt.
make: *** [init] Erreur 2


As far as I understand it, Makefile rule cmd_missing_syscalls (from
init/Makefile) is used twice in two different ways:
- At first compile:
  - run the command directly from Makefile,
  - dump this command to init/.missing_syscalls.h.cmd for further use;
- At every but first compile:
  - run existing init/.missing_syscalls.h.cmd


Can someone confirm that this is the right way to patch this ?



Thanks,
- Stéphane.

# complain-about-missing-system-calls-fix.patch
# Make generation of init/missing_syscalls.h more robust.
# Note: This fix is required only for "all but first" compilations, and
# perhaps only on some configurations (cf. /bin/sh).

Signed-off-by: Stéphane (kwisatz) Jourdois <kwisatz@rubis.org>

diff -uNr linux-2.6.21-rc4-mm1.orig/init/Makefile linux-2.6.21-rc4-mm1/init/Makefile
--- linux-2.6.21-rc4-mm1.orig/init/Makefile	2007-03-20 09:54:23.000000000 +0100
+++ linux-2.6.21-rc4-mm1/init/Makefile	2007-03-20 11:19:02.000000000 +0100
@@ -35,10 +35,8 @@
 
 
 quiet_cmd_missing_syscalls = GEN     $@
-      cmd_missing_syscalls = sed -n '/^\#define/s/[^_]*__NR_\([^[:space:]]*\).*/\
-	\#if !defined (__NR_\1) \&\& !defined (__IGNORE_\1)\n\
-	\#warning syscall \1 not implemented\n\
-	\#endif/p' $(srctree)/include/asm-i386/unistd.h >$@
+      cmd_missing_syscalls = sed -n -f scripts/mkmissing_syscalls_h \
+      			$(srctree)/include/asm-i386/unistd.h >$@
 targets += missing_syscalls.h
 $(obj)/missing_syscalls.h: include/asm-i386/unistd.h
 	$(call if_changed,missing_syscalls)
diff -uNr linux-2.6.21-rc4-mm1.orig/scripts/mkmissing_syscalls_h linux-2.6.21-rc4-mm1/scripts/mkmissing_syscalls_h
--- linux-2.6.21-rc4-mm1.orig/scripts/mkmissing_syscalls_h	1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.21-rc4-mm1/scripts/mkmissing_syscalls_h	2007-03-20 11:34:21.000000000 +0100
@@ -0,0 +1,6 @@
+/^\#define/ {
+	s/[^_]*__NR_\([^[:space:]]*\).*/\
+\#if !defined (__NR_\1) \&\& !defined (__IGNORE_\1)\
+\#warning syscall \1 not implemented\
+\#endif/p
+}

-- 
 ///  Stephane Jourdois     /"\  ASCII RIBBON CAMPAIGN \\\
(((    Consultant securite  \ /    AGAINST HTML MAIL    )))
 \\\   24 rue Cauchy         X                         ///
  \\\  75015  Paris         / \    +33 6 8643 3085    ///
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.21-rc4-mm1, Andrew Morton, (Tue Mar 20, 12:56 am)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 5:57 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Mon Mar 26, 6:22 pm)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 7:43 pm)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 4:05 pm)
Re: 2.6.21-rc4-mm1, Jean Delvare, (Mon Mar 26, 3:35 pm)
Re: 2.6.21-rc4-mm1, Greg KH, (Mon Mar 26, 7:26 pm)
Re: 2.6.21-rc4-mm1, Badari Pulavarty, (Mon Mar 26, 3:47 pm)
Re: 2.6.21-rc4-mm1, Paul Mackerras, (Mon Mar 26, 7:29 pm)
[-mm patch] unexport bio_{,un}map_user, Adrian Bunk, (Sat Mar 24, 9:07 am)
[-mm patch] lguest: #if 0 check_bug_kill(), Adrian Bunk, (Sat Mar 24, 9:06 am)
Re: [-mm patch] lguest: #if 0 check_bug_kill(), Rusty Russell, (Sun Mar 25, 3:33 am)
[-mm patch] lguest: remove check_bug_kill(), Adrian Bunk, (Sun Mar 25, 10:57 am)
Re: 2.6.21-rc4-mm1, J.A. , (Thu Mar 22, 7:27 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Mon Mar 26, 4:31 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Thu Mar 22, 9:41 pm)
Re: 2.6.21-rc4-mm1, Reuben Farrelly, (Wed Mar 21, 6:14 am)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 9:47 pm)
Re: 2.6.21-rc4-mm1, Greg KH, (Wed Mar 21, 2:36 pm)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 7:49 pm)
FireWire update in -mm (was 2.6.21-rc4-mm1), Stefan Richter, (Tue Mar 20, 7:10 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Tue Mar 20, 5:04 pm)
Re: 2.6.21-rc4-mm1: multiple definition of `queue_pushbutton..., Kristen Carlson Accardi, (Wed Mar 21, 2:45 pm)
[PATCH] utrace: make an inline void, Randy Dunlap, (Tue Mar 20, 2:09 pm)
Re: [PATCH] utrace: make an inline void, Roland McGrath, (Tue Mar 20, 9:48 pm)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 1:31 pm)
Re: 2.6.21-rc4-mm1, Kees Cook, (Tue Mar 20, 3:20 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Wed Mar 21, 1:47 am)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Wed Mar 21, 6:19 pm)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Wed Mar 21, 7:01 pm)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Thu Mar 22, 4:54 am)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Wed Mar 21, 7:59 am)
Re: 2.6.21-rc4-mm1, David Woodhouse, (Thu Mar 22, 5:17 am)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Thu Mar 22, 7:41 am)
Re: 2.6.21-rc4-mm1, David Woodhouse, (Thu Mar 22, 12:25 pm)
Re: 2.6.21-rc4-mm1, Sam Ravnborg, (Thu Mar 22, 12:28 pm)
Re: 2.6.21-rc4-mm1, David Woodhouse, (Wed Mar 21, 7:25 am)
Re: 2.6.21-rc4-mm1, Randy Dunlap, (Tue Mar 20, 4:50 pm)
Re: 2.6.21-rc4-mm1, Stéphane Jourdois, (Tue Mar 20, 4:42 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Tue Mar 20, 12:36 pm)
Re: 2.6.21-rc4-mm1, J.A. , (Tue Mar 20, 8:14 pm)
Re: 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 10:31 am)
Re: 2.6.21-rc4-mm1, Andrew Morton, (Tue Mar 20, 12:09 pm)
Re: 2.6.21-rc4-mm1, Pavel Machek, (Tue Mar 20, 2:38 pm)
Re: 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 3:40 pm)
Re: 2.6.21-rc4-mm1, Rafael J. Wysocki, (Tue Mar 20, 4:12 pm)
Re: 2.6.21-rc4-mm1, Pavel Machek, (Tue Mar 20, 3:56 pm)
Re: 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 4:13 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Pavel Machek, (Tue Mar 20, 4:21 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Rafael J. Wysocki, (Tue Mar 20, 4:58 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Jiri Slaby, (Tue Mar 20, 4:58 pm)
Re: [linux-pm] 2.6.21-rc4-mm1, Rafael J. Wysocki, (Tue Mar 20, 5:06 pm)
Re: 2.6.21-rc4-mm1 [PATCH] init/missing_syscalls.h fix, Stephane Jourdois, (Tue Mar 20, 6:52 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Tue Mar 20, 5:45 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 4:41 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 5:48 am)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Thu Mar 22, 6:04 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 1:07 pm)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Thu Mar 22, 2:17 pm)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Fri Mar 23, 2:18 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Fri Mar 23, 4:45 am)
Re: 2.6.21-rc4-mm1, Andy Whitcroft, (Fri Mar 23, 8:28 am)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Fri Mar 23, 5:45 pm)
debug rsdl 0.33, Con Kolivas, (Fri Mar 23, 7:26 pm)
Re: debug rsdl 0.33, Torsten Kaiser, (Sun Mar 25, 2:28 pm)
Re: debug rsdl 0.33, Con Kolivas, (Sun Mar 25, 6:49 pm)
Re: debug rsdl 0.33, Con Kolivas, (Sun Mar 25, 6:59 pm)
Re: debug rsdl 0.33, Andy Whitcroft, (Mon Mar 26, 3:49 am)
Re: debug rsdl 0.33, Andy Whitcroft, (Mon Mar 26, 11:28 am)
Re: debug rsdl 0.33, Con Kolivas, (Mon Mar 26, 12:12 pm)
Re: debug rsdl 0.33, Andrew Morton, (Sun Mar 25, 6:01 pm)
Re: debug rsdl 0.33, Andy Whitcroft, (Sun Mar 25, 8:27 am)
Re: 2.6.21-rc4-mm1, Con Kolivas, (Thu Mar 22, 6:14 pm)
Re: 2.6.21-rc4-mm1, Michal Piotrowski, (Tue Mar 20, 3:54 am)
speck-geostationary