On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote:

quoted text
> Attached below is the patch which implements this system call. It has

> been currently implemented and tested on i386, ppc64 and x86_64

> architectures. I am facing some problems while trying to implement this

> on s390, and thus the delay. While I try to get it right on s390(x), we

> thought of posting this patch, so that we can save some time. Parallely

> we will work on getting the patch work on s390, and probably it will

> come as a separate patch.

I suggest reading the very end of arch/arm/kernel/sys_arm.c; I'd rather

avoid adding more and more hacks like that to the kernel if at all

possible.
One solution (already mentioned elsewhere) is that we start avoiding

passing 64-bit arguments and instead pass two 32-bit instead.  This

nicely avoids the alignment restrictions for 64-bit args in ABIs.
(The issue for ARM is that with anything other than the "fd, mode,

offset, len" layout we will have to deal with different ABI argument

layouts, or implement our own wrapper function as done for

sys_arm_sync_file_range.)
I think the problem comes down to "what is the argument layout which

causes the least amount of problems for the complete set of architectures."

For ARM, that's the "fd, mode, offset, len" layout.
--

Russell King

 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/

 maintainer of:

-

unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please read the FAQ at  http://www.tux.org/lkml/