On Wed, 14 Mar 2007, Frank Seidel wrote:
quoted text > On Monday 12 March 2007 20:19:27 Davide Libenzi wrote:
> Hi,
> i'm not (at least until yet) really that familiar with the kernel, but=20
> currently trying to get into it also via reading of code and patches=20
> here. So please don't take my comments in this (and posibly following)
> mails to serious. ;-)
>=20
> > +asmlinkage long compat_sys_signalfd(int ufd,
> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0 =A0 =A0const compat_sigset_t __user=20
quoted text > *sigmask,
> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0 =A0 =A0compat_size_t sigsetsize)
quoted text > > +{
> > +=A0=A0=A0=A0=A0compat_sigset_t ss32;
> > +=A0=A0=A0=A0=A0sigset_t tmp;
> > +=A0=A0=A0=A0=A0sigset_t __user *ksigmask;
> > +
> Would it be good to put this in a
>=20
> if (sigmask) {
>=20
> like its e.g. done in compat_sys_epoll_pwait or would this be
> totally useless here?
On the contrary or epoll_pwait (same family of ppoll/pselect), the sigmask=
=20
is needed here, by the API definition.
- Davide
