Home » Mailing list archives » linux-kernel » 2007 » March » 12

[PATCH 2/3] lumpy: back out removal of active check in isolate_lru_pages

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andy Whitcroft <apw@...>
To: Andrew Morton <akpm@...>
Cc: <linux-mm@...>, <linux-kernel@...>, Andy Whitcroft <apw@...>, Mel Gorman <mel@...>
Subject: [PATCH 2/3] lumpy: back out removal of active check in isolate_lru_pages
Date: Monday, March 12, 2007 - 2:23 pm

As pointed out by Christop Lameter it should not be possible for a
page to change its active/inactive state without taking the lru_lock.
Reinstate this safety net.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Acked-by: Mel Gorman <mel@csn.ul.ie>
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index bda63a0..d7a0860 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -691,10 +691,13 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
 			nr_taken++;
 			break;
 
-		default:
-			/* page is being freed, or is a missmatch */
+		case -EBUSY:
+			/* else it is being freed elsewhere */
 			list_move(&page->lru, src);
 			continue;
+
+		default:
+			BUG();
 		}
 
 		if (!order)
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 2/3] lumpy: back out removal of active check in isola..., Andy Whitcroft, (Mon Mar 12, 2:23 pm)