module.h and moduleparam.h: more header file pedantry

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linux Kernel Mailing List <linux-kernel@...>
Date: Monday, March 12, 2007 - 12:59 pm

well, since my last adventure with header files went over so
swimmingly, i might as well keep going.  :-)

  to my surprise, i learned only today that module.h includes
moduleparam.h, which flies in the face of all of the documentation
i've ever read which was adamant that i *had* to include moduleparam.h
if i was using parameters. i'm guessing this comes as a surprise to
the 400+ header files which include both unnecessarily.

  so ... in a perfect world, should a module source file that doesn't
use parameters *at all* need to include moduleparam.h?  as it stands
now, yes, it does, given some ugly inter-dependencies between the two
files.

  so, at the very least, programmers can stop including moduleparam.h,
unless there's a cleaner way to do all that.

rday


-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
module.h and moduleparam.h: more header file pedantry, Robert P. J. Day, (Mon Mar 12, 12:59 pm)
Re: module.h and moduleparam.h: more header file pedantry, Alexey Dobriyan, (Tue Mar 13, 6:05 pm)
Re: module.h and moduleparam.h: more header file pedantry, Robert P. J. Day, (Tue Mar 13, 6:04 pm)