Re: [PATCH] ext3: dirindex error pointer issues (b)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dmitriy Monakhov
Date: Monday, March 12, 2007 - 12:20 am

Dmitriy Monakhov <dmonakhov@sw.ru> writes:

Ohh my first patch change error message semantics in do_split(). Initially when 
ext3_append() failed we just exit without printing error. In fact ext3_append()
may fail, it is legal and it's happens qite often (ENOSPC for example). This 
cause annoying fake error message. So restore this semantic as it was before
patch.
Andrew please apply incremental patch what fix it:

Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>

diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
index 1a52586..7edb617 100644
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -1197,8 +1197,8 @@ journal_error:
 	brelse(*bh);
 	brelse(bh2);
 	*bh = NULL;
-errout:
 	ext3_std_error(dir->i_sb, err);
+errout:
 	*error = err;
 	return NULL;
 }
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index f0a6c26..02a75db 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1195,8 +1195,8 @@ journal_error:
 	brelse(*bh);
 	brelse(bh2);
 	*bh = NULL;
-errout:
 	ext4_std_error(dir->i_sb, err);
+errout:
 	*error = err;
 	return NULL;
 }

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ext3: dirindex error pointer issues , Dmitriy Monakhov, (Sun Mar 4, 7:18 am)
Re: [PATCH] ext3: dirindex error pointer issues, Andreas Dilger, (Sun Mar 4, 7:13 pm)
Re: [PATCH] ext3: dirindex error pointer issues, Dmitriy Monakhov, (Mon Mar 5, 12:34 am)
Re: [PATCH] ext3: dirindex error pointer issues (b), Dmitriy Monakhov, (Mon Mar 12, 12:20 am)