login
Header Space

 
 

[PATCH] fix cc-option-yn whitespace

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>
Cc: <linux-kernel@...>
Date: Wednesday, February 7, 2007 - 11:30 pm

This change:

	commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7
	Author: Oleg Verych <olecom@flower.upol.cz>
	Date:   Tue Feb 6 02:18:21 2007 +0100

	    [PATCH] kbuild: improve option checking, Kbuild.include cleanup

introduced leading whitespace in the results of cc-option-yn and such.
This breaks some of their uses, like HAS_MTUNE in arch/i386/Makefile.cpu.

This patch fixes the regression.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 scripts/Kbuild.include |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 96926eb..931d52f 100644  
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -60,6 +60,7 @@ endef
 # Usage: option = $(call checker-shell, $(CC)...-o $$OUT, option-ok, otherwise)
 # Exit code chooses option. $$OUT is safe location for needless output.
 define checker-shell
+$(strip \
   $(shell set -e; \
     DIR=$(KBUILD_EXTMOD); \
     cd $${DIR:-$(objtree)}; \
@@ -70,7 +71,7 @@ define checker-shell
       then echo "$(2)"; \
       else echo "$(3)"; \
     fi; \
-    rm -f $$OUT)
+    rm -f $$OUT))
 endef
 
 # as-option
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] fix cc-option-yn whitespace, Roland McGrath, (Wed Feb 7, 11:30 pm)
Re: [PATCH] fix cc-option-yn whitespace, Linus Torvalds, (Thu Feb 8, 12:34 am)
Re: [PATCH] fix cc-option-yn whitespace, Roland McGrath, (Thu Feb 8, 4:06 pm)
Re: [PATCH] fix cc-option-yn whitespace, Oleg Verych, (Thu Feb 8, 4:54 pm)
speck-geostationary