login
Header Space

 
 

[-mm patch] drivers/scsi/aacraid/: cleanups

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, <James.Bottomley@...>
Cc: <linux-kernel@...>, <linux-scsi@...>
Date: Tuesday, February 6, 2007 - 6:12 pm

On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote:


This patch contains the following cleanups:
- proper prototypes for global code in aacraid.h
- aac_rx_start_adapter() can now become static

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/aacraid/aacraid.h |    3 +++
 drivers/scsi/aacraid/linit.c   |    2 --
 drivers/scsi/aacraid/nark.c    |    3 ---
 drivers/scsi/aacraid/rkt.c     |    3 ---
 drivers/scsi/aacraid/rx.c      |    2 +-
 5 files changed, 4 insertions(+), 9 deletions(-)

--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/aacraid.h.old	2007-02-06 08:22:50.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/aacraid.h	2007-02-06 08:27:17.000000000 +0100
@@ -1840,8 +1840,11 @@
 int aac_get_adapter_info(struct aac_dev* dev);
 int aac_send_shutdown(struct aac_dev *dev);
 int aac_probe_container(struct aac_dev *dev, int cid);
+int _aac_rx_init(struct aac_dev *dev);
+int aac_rx_select_comm(struct aac_dev *dev, int comm);
 extern int numacb;
 extern int acbsize;
 extern char aac_driver_version[];
 extern int startup_timeout;
 extern int aif_timeout;
+extern int expose_physicals;
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rx.c.old	2007-02-06 08:21:40.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rx.c	2007-02-06 08:21:50.000000000 +0100
@@ -294,7 +294,7 @@
  *	Start up processing on an i960 based AAC adapter
  */
 
-void aac_rx_start_adapter(struct aac_dev *dev)
+static void aac_rx_start_adapter(struct aac_dev *dev)
 {
 	struct aac_init *init;
 
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/linit.c.old	2007-02-06 08:23:20.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/linit.c	2007-02-06 08:23:26.000000000 +0100
@@ -82,8 +82,6 @@
 static int aac_cfg_major = -1;
 char aac_driver_version[] = AAC_DRIVER_FULL_VERSION;
 
-extern int expose_physicals;
-
 /*
  * Because of the way Linux names scsi devices, the order in this table has
  * become important.  Check for on-board Raid first, add-in cards second.
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/nark.c.old	2007-02-06 08:24:47.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/nark.c	2007-02-06 08:24:58.000000000 +0100
@@ -74,9 +74,6 @@
 
 int aac_nark_init(struct aac_dev * dev)
 {
-	extern int _aac_rx_init(struct aac_dev *dev);
-	extern int aac_rx_select_comm(struct aac_dev *dev, int comm);
-
 	/*
 	 *	Fill in the function dispatch table.
 	 */
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rkt.c.old	2007-02-06 08:25:07.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rkt.c	2007-02-06 08:25:20.000000000 +0100
@@ -45,7 +45,6 @@
 static int aac_rkt_select_comm(struct aac_dev *dev, int comm)
 {
 	int retval;
-	extern int aac_rx_select_comm(struct aac_dev *dev, int comm);
 	retval = aac_rx_select_comm(dev, comm);
 	if (comm == AAC_COMM_MESSAGE) {
 		/*
@@ -97,8 +96,6 @@
 
 int aac_rkt_init(struct aac_dev *dev)
 {
-	extern int _aac_rx_init(struct aac_dev *dev);
-
 	/*
 	 *	Fill in the function dispatch table.
 	 */

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.20-rc6-mm3, Andrew Morton, (Tue Jan 30, 12:45 am)
[-mm patch] make gfs2_writepages() static, Adrian Bunk, (Tue Feb 6, 6:12 pm)
Re: [-mm patch] make gfs2_writepages() static, Steven Whitehouse, (Wed Feb 7, 6:50 am)
[-mm patch] drivers/scsi/aacraid/: cleanups, Adrian Bunk, (Tue Feb 6, 6:12 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 12:03 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 2:36 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 2:45 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 3:07 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 3:55 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 4:20 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 4:40 pm)
Re: 2.6.20-rc6-mm3, Rob Landley, (Tue Feb 6, 7:15 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 7:28 pm)
Re: 2.6.20-rc6-mm3, Rob Landley, (Tue Feb 6, 7:55 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 5:17 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 5:25 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 4:52 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 4:56 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 5:09 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 5:23 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 5:43 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 5:59 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 5:41 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 5:54 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 6:13 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 6:08 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 6:42 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 6:56 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 7:04 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 7:14 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 7:22 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 7:37 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 7:36 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 9:12 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Wed Feb 7, 10:53 am)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 7:28 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 7:35 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 7:51 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Tue Feb 6, 10:46 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Tue Feb 6, 7:44 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Tue Feb 6, 5:20 pm)
Re: 2.6.20-rc6-mm3, Daniel Walker, (Fri Feb 2, 1:39 pm)
Re: 2.6.20-rc6-mm3, Cedric Le Goater, (Thu Feb 1, 2:24 pm)
RE: 2.6.20-rc6-mm3, Starikovskiy, Alexey Y, (Thu Feb 1, 3:37 pm)
Re: 2.6.20-rc6-mm3, Cedric Le Goater, (Thu Feb 1, 4:29 pm)
Re: 2.6.20-rc6-mm3, Cedric Le Goater, (Thu Feb 1, 4:38 pm)
RE: 2.6.20-rc6-mm3, Starikovskiy, Alexey Y, (Fri Feb 2, 10:22 am)
Re: 2.6.20-rc6-mm3, Cedric Le Goater, (Fri Feb 2, 10:47 am)
RE: 2.6.20-rc6-mm3, Starikovskiy, Alexey Y, (Fri Feb 2, 10:50 am)
Re: 2.6.20-rc6-mm3, Cedric Le Goater, (Fri Feb 2, 12:04 pm)
Re: 2.6.20-rc6-mm3, Cedric Le Goater, (Sat Feb 3, 3:30 am)
RE: 2.6.20-rc6-mm3, Starikovskiy, Alexey Y, (Sat Feb 3, 3:57 am)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Wed Jan 31, 8:14 pm)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Wed Jan 31, 8:24 pm)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Wed Jan 31, 8:27 pm)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Wed Jan 31, 8:36 pm)
Re: 2.6.20-rc6-mm3, David Chinner, (Thu Feb 1, 2:20 am)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Thu Feb 1, 3:12 am)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Thu Feb 1, 3:01 pm)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Thu Feb 1, 3:18 pm)
Re: 2.6.20-rc6-mm3, David Chinner, (Fri Feb 2, 12:08 am)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Fri Feb 2, 3:31 am)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Thu Feb 1, 4:18 pm)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Thu Feb 1, 4:26 pm)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Thu Feb 1, 7:02 pm)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Mon Feb 5, 8:02 am)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Mon Feb 5, 8:17 am)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Mon Feb 5, 8:56 am)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Mon Feb 5, 2:20 pm)
Re: 2.6.20-rc6-mm3, Jens Axboe, (Mon Feb 5, 2:34 pm)
Re: 2.6.20-rc6-mm3, Christoph Lameter, (Wed Jan 31, 8:38 pm)
Re: 2.6.20-rc6-mm3, Mattia Dongili, (Wed Jan 31, 5:52 pm)
Re: 2.6.20-rc6-mm3, Mattia Dongili, (Wed Jan 31, 7:21 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Thu Feb 1, 3:36 pm)
Re: 2.6.20-rc6-mm3, Mattia Dongili, (Thu Feb 1, 4:24 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Thu Feb 1, 4:01 pm)
Re: 2.6.20-rc6-mm3, Mattia Dongili, (Thu Feb 1, 5:37 pm)
Re: 2.6.20-rc6-mm3, Mattia Dongili, (Thu Feb 1, 5:11 pm)
Re: 2.6.20-rc6-mm3, Thomas Gleixner, (Thu Feb 1, 6:33 pm)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Thu Feb 1, 3:04 pm)
Re: 2.6.20-rc6-mm3, Maciej Rutecki, (Tue Jan 30, 6:18 pm)
Re: 2.6.20-rc6-mm3, Tilman Schmidt, (Tue Jan 30, 9:16 pm)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Tue Jan 30, 9:25 pm)
Re: 2.6.20-rc6-mm3, Tilman Schmidt, (Wed Jan 31, 7:38 am)
Re: 2.6.20-rc6-mm3, Alexey Starikovskiy, (Wed Jan 31, 8:29 am)
Re: 2.6.20-rc6-mm3, Tilman Schmidt, (Wed Jan 31, 2:28 pm)
Re: 2.6.20-rc6-mm3, Maciej Rutecki, (Wed Jan 31, 12:02 pm)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Tue Jan 30, 6:27 pm)
Re: 2.6.20-rc6-mm3, Maciej Rutecki, (Wed Jan 31, 7:54 am)
Re: 2.6.20-rc6-mm3, Len Brown, (Thu Feb 1, 12:10 am)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Thu Feb 1, 12:17 am)
Re: 2.6.20-rc6-mm3, Karsten Wiese, (Tue Jan 30, 8:55 pm)
[PATCH -mm] gtod persistent clock resume fix, Thomas Gleixner, (Thu Feb 1, 9:03 am)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Wed Jan 31, 9:22 am)
Re: 2.6.20-rc6-mm3, Karsten Wiese, (Wed Jan 31, 10:25 am)
Re: 2.6.20-rc6-mm3, Ingo Molnar, (Thu Feb 1, 4:01 am)
Re: 2.6.20-rc6-mm3, Pavel Machek, (Fri Feb 2, 8:37 pm)
Re: 2.6.20-rc6-mm3, Karsten Wiese, (Thu Feb 1, 6:44 am)
Re: 2.6.20-rc6-mm3, Karsten Wiese, (Thu Mar 1, 7:11 am)
Re: 2.6.20-rc6-mm3, Olivier Galibert, (Tue Jan 30, 5:06 am)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Tue Jan 30, 5:26 am)
Re: 2.6.20-rc6-mm3, Len Brown, (Thu Feb 1, 12:25 am)
Re: 2.6.20-rc6-mm3, Len Brown, (Wed Jan 31, 3:57 am)
Re: 2.6.20-rc6-mm3, Olivier Galibert, (Tue Jan 30, 2:47 pm)
Re: 2.6.20-rc6-mm3, Sunil Naidu, (Tue Jan 30, 4:16 am)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Tue Jan 30, 4:32 am)
Re: 2.6.20-rc6-mm3, Jeff Garzik, (Tue Jan 30, 12:50 am)
Re: 2.6.20-rc6-mm3, Andrew Morton, (Tue Jan 30, 1:11 am)
Re: 2.6.20-rc6-mm3, Evgeniy Polyakov, (Tue Jan 30, 5:56 am)
speck-geostationary