Home » Mailing list archives » linux-kernel » 2007 » February » 6

[PATCH -mm][AIO] AIO completion signal notification small cleanup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Sébastien Dugué
Subject: [PATCH -mm][AIO] AIO completion signal notification small cleanup
Date: Tuesday, February 6, 2007 - 4:57 am

Andrew, one more cleanup to aio_setup_sigevent() to make it more readable.

  Sébastien.


From: Sébastien Dugué <sebastien.dugue@bull.net>

	AIO completion signal notification small cleanup

  This patch cleans up aio_setup_sigevent() to make it more readable.

 aio.c |   15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

Signed-off-by: Sébastien Dugué <sebastien.dugue@bull.net>


Index: linux-2.6.20-rc6-mm3/fs/aio.c
===================================================================
--- linux-2.6.20-rc6-mm3.orig/fs/aio.c	2007-02-06 09:33:55.000000000 +0100
+++ linux-2.6.20-rc6-mm3/fs/aio.c	2007-02-06 12:43:52.000000000 +0100
@@ -962,21 +962,11 @@ static long aio_setup_sigevent(struct ai
 	    event.sigev_notify != SIGEV_THREAD_ID)
 		return -EINVAL;
 
-	notify->notify = event.sigev_notify;
-	notify->signo = event.sigev_signo;
-	notify->value = event.sigev_value;
-
 	rcu_read_lock();
 	target = sigevent_find_task(&event);
 
-	if (unlikely(!target)) {
-		/*
-		 * Revert notify to SIGEV_NONE so that really_put_req()
-		 * knows that no ref has been taken on a task.
-		 */
-		notify->notify = SIGEV_NONE;
+	if (unlikely(!target))
 		goto out_unlock;
-	}
 
 	/*
 	 * At this point, we know that notify is either SIGEV_SIGNAL or
@@ -988,6 +978,9 @@ static long aio_setup_sigevent(struct ai
 	notify->target = target;
 	rcu_read_unlock();
 
+	notify->notify = event.sigev_notify;
+	notify->signo = event.sigev_signo;
+	notify->value = event.sigev_value;
 	notify->sigq = __sigqueue_alloc(current, GFP_KERNEL, 0);
 
 	/*
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH -mm 0/7][AIO] - AIO completion signal notification v6, Sébastien Dugué, (Thu Feb 1, 2:22 am)
[PATCH -mm 1/7][AIO] - Rework compat_sys_io_submit, Sébastien Dugué, (Thu Feb 1, 2:26 am)
[PATCH -mm 2/7][AIO] - fix aio.h includes, Sébastien Dugué, (Thu Feb 1, 2:29 am)
[PATCH -mm 3/7][AIO] - Fix access_ok() checks, Sébastien Dugué, (Thu Feb 1, 2:30 am)
[PATCH -mm 4/7][AIO] - Make good_sigevent() non-static, Sébastien Dugué, (Thu Feb 1, 2:30 am)
[PATCH -mm 5/7][AIO] - Make __sigqueue_free() and __sigque ..., Sébastien Dugué, (Thu Feb 1, 2:31 am)
[PATCH -mm 6/7][AIO] - AIO completion signal notification, Sébastien Dugué, (Thu Feb 1, 2:31 am)
[PATCH -mm 7/7][AIO] - Add listio syscall support, Sébastien Dugué, (Thu Feb 1, 2:32 am)
Re: [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static, Oleg Nesterov, (Fri Feb 2, 11:00 am)
Re: [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static, Sébastien Dugué, (Mon Feb 5, 4:09 am)
[PATCH -mm 4/7][AIO] Resend - Make good_sigevent() non-static, Sébastien Dugué, (Mon Feb 5, 5:18 am)
Re: [PATCH -mm 4/7][AIO] Resend - Make good_sigevent() non ..., Oleg Nesterov, (Mon Feb 5, 6:43 am)
[PATCH -mm][AIO] Fix AIO completion signal notification po ..., Sébastien Dugué, (Mon Feb 5, 9:00 am)
Re: [PATCH -mm][AIO] Fix AIO completion signal notificatio ..., Oleg Nesterov, (Mon Feb 5, 10:13 am)
Re: [PATCH -mm][AIO] Fix AIO completion signal notificatio ..., Sébastien Dugué, (Tue Feb 6, 1:31 am)
[PATCH -mm][AIO] AIO completion signal notification fixes ..., Sébastien Dugué, (Tue Feb 6, 2:22 am)
Re: [PATCH -mm][AIO] AIO completion signal notification fi ..., Oleg Nesterov, (Tue Feb 6, 4:05 am)
Re: [PATCH -mm][AIO] AIO completion signal notification fi ..., Sébastien Dugué, (Tue Feb 6, 4:39 am)
[PATCH -mm][AIO] AIO completion signal notification small ..., Sébastien Dugué, (Tue Feb 6, 4:57 am)