[patch] MTD: fix DOC2000/2001/2001PLUS build error

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Monday, February 5, 2007 - 1:45 am

* Linus Torvalds <torvalds@linux-foundation.org> wrote:


i am honored to present the very first build fix for v2.6.20, as a
tribute to the Colts.

	Ingo

-------------------->
Subject: [patch] MTD: fix DOC2000/2001/2001PLUS build error
From: Ingo Molnar <mingo@elte.hu>

The very first "make ARCH=i386 randconfig" gave this build error:

    LD      vmlinux
  drivers/built-in.o: In function `cafe_nand_remove':
  cafe.c:(.text+0x19277a): undefined reference to `nand_release'
  drivers/built-in.o: In function `cafe_nand_cmdfunc':
  cafe.c:(.text+0x193036): undefined reference to `nand_wait_ready'
  drivers/built-in.o: In function `cafe_nand_probe':
  cafe.c:(.text+0x19359e): undefined reference to `nand_scan_ident'
  cafe.c:(.text+0x193658): undefined reference to `nand_scan_tail'
  distcc[1703] ERROR: compile (null) on localhost failed
  make: *** [vmlinux] Error 1

which i suspect was a side-effect of the late and optimistic MTD merge.

but hey, we always knew Linux was better at offense than at defense, and 
good offense is what wins the game in the end, as the Bears had to find 
out the hard way ;-)

so here's the fix for the 3 affected MTD drivers: DOC2000, DOC2001 and 
DOC2001PLUS.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/mtd/devices/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

Index: linux/drivers/mtd/devices/Kconfig
===================================================================
--- linux.orig/drivers/mtd/devices/Kconfig
+++ linux/drivers/mtd/devices/Kconfig
@@ -152,6 +152,7 @@ config MTD_DOC2000
 	tristate "M-Systems Disk-On-Chip 2000 and Millennium (DEPRECATED)"
 	depends on MTD
 	select MTD_DOCPROBE
+	select MTD_NAND
 	select MTD_NAND_IDS
 	---help---
 	  This provides an MTD device driver for the M-Systems DiskOnChip
@@ -175,6 +176,7 @@ config MTD_DOC2001
 	tristate "M-Systems Disk-On-Chip Millennium-only alternative driver (DEPRECATED)"
 	depends on MTD
 	select MTD_DOCPROBE
+	select MTD_NAND
 	select MTD_NAND_IDS
 	---help---
 	  This provides an alternative MTD device driver for the M-Systems
@@ -197,6 +199,7 @@ config MTD_DOC2001PLUS
 	tristate "M-Systems Disk-On-Chip Millennium Plus"
 	depends on MTD
 	select MTD_DOCPROBE
+	select MTD_NAND
 	select MTD_NAND_IDS
 	---help---
 	  This provides an MTD device driver for the M-Systems DiskOnChip
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Super Kernel Sunday!, Linus Torvalds, (Sun Feb 4, 12:10 pm)
Re: Super Kernel Sunday!, Bauke Jan Douma, (Sun Feb 4, 12:40 pm)
Re: Super Kernel Sunday!, Alessandro Suardi, (Sun Feb 4, 12:56 pm)
Re: Super Kernel Sunday!, Gene Heskett, (Sun Feb 4, 2:00 pm)
Re: Super Kernel Sunday!, Kevin K, (Sun Feb 4, 2:11 pm)
Re: Super Kernel Sunday!, Jonathan Sambrook, (Mon Feb 5, 1:39 am)
[patch] MTD: fix DOC2000/2001/2001PLUS build error, Ingo Molnar, (Mon Feb 5, 1:45 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 6:34 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Arjan van de Ven, (Mon Feb 5, 9:08 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Russell King, (Mon Feb 5, 9:12 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 9:22 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 9:32 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 9:33 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Russell King, (Mon Feb 5, 9:46 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Russell King, (Mon Feb 5, 9:50 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 9:52 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 9:58 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Russell King, (Mon Feb 5, 10:04 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Ingo Molnar, (Mon Feb 5, 10:05 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Russell King, (Mon Feb 5, 10:08 am)
Re: Super Kernel Sunday!, Jan Engelhardt, (Mon Feb 5, 10:58 am)
Re: Super Kernel Sunday!, Kevin Fox, (Mon Feb 5, 11:07 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 2:17 pm)
[2.6.20] Regression in dmfe driver, Thomas Bächler, (Mon Feb 5, 2:27 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 2:28 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 2:39 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 2:41 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 2:49 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 2:53 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 3:21 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Randy Dunlap, (Mon Feb 5, 3:31 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 3:35 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 4:09 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Mon Feb 5, 4:21 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Mon Feb 5, 4:32 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Theodore Tso, (Mon Feb 5, 6:09 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Matt Mackall, (Mon Feb 5, 10:46 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Matt Mackall, (Mon Feb 5, 11:09 pm)
Re: [2.6.20] Regression in dmfe driver, Thierry Vignaud, (Tue Feb 6, 2:38 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 2:45 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Gerhard Mack, (Tue Feb 6, 6:32 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Bill Davidsen, (Tue Feb 6, 8:41 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Bill Davidsen, (Tue Feb 6, 8:51 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Bill Davidsen, (Tue Feb 6, 8:55 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Bill Davidsen, (Tue Feb 6, 9:04 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Matt Mackall, (Tue Feb 6, 9:41 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 9:53 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Bill Davidsen, (Tue Feb 6, 11:03 am)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 3:38 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Haavard Skinnemoen, (Tue Feb 6, 3:39 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Randy Dunlap, (Tue Feb 6, 3:39 pm)
Re: [2.6.20] Regression in dmfe driver, Thomas Bächler, (Tue Feb 6, 3:40 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 3:51 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 3:53 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 4:11 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 4:11 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 4:15 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 4:18 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 4:28 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 4:36 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Randy Dunlap, (Tue Feb 6, 4:41 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 4:49 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 4:49 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Robert P. J. Day, (Tue Feb 6, 4:52 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 4:55 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 5:03 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 5:21 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Randy Dunlap, (Tue Feb 6, 5:30 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, David Woodhouse, (Tue Feb 6, 5:37 pm)
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error, Linus Torvalds, (Tue Feb 6, 7:09 pm)
Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S, Philipp Matthias Hahn, (Tue Feb 27, 6:58 am)
Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S, Philipp Matthias Hahn, (Mon Mar 5, 3:38 am)
Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S, Philipp Matthias Hahn, (Tue Mar 6, 2:23 am)