On Wed, 28 Feb 2007 15:40:31 -0700
"Dale Farnsworth" <dale@farnsworth.org> wrote:

quoted text
> The information contained within platform_data should be self-contained.
> Replace the pointer to a MAC address with the actual MAC address in
> struct mv643xx_eth_platform_data.
> 
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
> 
> Index: b/drivers/net/mv643xx_eth.c
> ===================================================================
> --- a/drivers/net/mv643xx_eth.c
> +++ b/drivers/net/mv643xx_eth.c
> @@ -1380,7 +1380,9 @@ static int mv643xx_eth_probe(struct plat
>  
>  	pd = pdev->dev.platform_data;
>  	if (pd) {
> -		if (pd->mac_addr)
> +		static u8 zero_mac_addr[6] = { 0 };
> +
> +		if (memcmp(pd->mac_addr, zero_mac_addr, 6) != 0)
>  			memcpy(dev->dev_addr, pd->mac_addr, 6);


is_zero_ether_addr() is faster/cleaner for this

-- 
Stephen Hemminger <shemminger@linux-foundation.org>
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/