Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Wednesday, February 28, 2007 - 10:34 am

On Wed, 28 Feb 2007, Jiri Kosina wrote:

"Not the best place for it" is the understatement of the year.

It's totally idiotic. 


*NO*.

Dammit, we don't put static initializers in header files. We don't 
duplicate the data in every single thing that includes a header file. If 
you want to duplicate the data, you export it as a real data structure, 
and you *still* put the data structure in a .c file.


WHAT CLEANUP? The thing is the anti-thesis of a "cleanup". There is no 
excuse for putting a large array in a header file and including it 
millions of times. Or even just twice. The point of a header file is to 
*declare* things, not to have big data structures in.

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] HID and USB HID update for 2.6.21-rc2, Jiri Kosina, (Wed Feb 28, 3:19 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Linus Torvalds, (Wed Feb 28, 10:09 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Jiri Kosina, (Wed Feb 28, 10:25 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Linus Torvalds, (Wed Feb 28, 10:34 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Jiri Kosina, (Wed Feb 28, 10:41 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Linus Torvalds, (Wed Feb 28, 11:20 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Linus Torvalds, (Wed Feb 28, 11:28 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Jiri Kosina, (Wed Feb 28, 11:29 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Randy Dunlap, (Wed Feb 28, 11:33 am)
Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2, Linus Torvalds, (Wed Feb 28, 11:39 am)