a bug in AS scheduler?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Xiaoning Ding
Date: Tuesday, February 27, 2007 - 9:22 pm

Hi,

I am reading the source code AS scheduler in 2.6.18(as-ioscheduler.c).
In function as_close_req, variable delay is in millisecond, while
ad->antic_expire is in jiffies. Doesn't the comparison of delay and
ad->antic_expire make any problem?
The related source code is quoted blow:

	if (ad->antic_status == ANTIC_OFF || !ad->ioc_finished)
		delay = 0;
	else
		delay = ((jiffies - ad->antic_start) * 1000) / HZ;

	if (delay == 0)
		delta = 8192;
	else if (delay <= 20 && delay <= ad->antic_expire)
		delta = 8192 << delay;
	else
		return 1;


Xiaoning
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
a bug in AS scheduler?, Xiaoning Ding, (Tue Feb 27, 9:22 pm)
Re: a bug in AS scheduler?, Jens Axboe, (Wed Feb 28, 5:10 am)
Re: a bug in AS scheduler?, Benoit Boissinot, (Wed Feb 28, 6:25 am)
Re: a bug in AS scheduler?, Jens Axboe, (Wed Feb 28, 6:34 am)
Re: a bug in AS scheduler?, Xiaoning Ding, (Wed Feb 28, 8:33 am)