Re: sparc64 / bbc_i2c.c

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <Joerg.Friedrich@...>
Cc: <j.j.green@...>, <akpm@...>, <linux-kernel@...>, <sparclinux@...>
Date: Tuesday, February 27, 2007 - 1:29 am

From: Joerg Friedrich <Joerg.Friedrich@friedrich-kn.de>
Date: Tue, 27 Feb 2007 06:22:39 +0100


I changed the check to just "val > 0".

The comments in the kernel around the implementation and
declaration of the function wait_event_interruptible()
VERY CLEARLY state that the possible return values are:

1) Negative error code on interrupt
2) Zero if timeout expired
3) Positive non-zero value if condition became true before
   timeout expired

So there is no doubt that "val > 0" is sufficient.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
sparc64 / bbc_i2c.c, J.J. Green, (Tue Feb 20, 9:27 am)
Re: sparc64 / bbc_i2c.c, Andrew Morton, (Sun Feb 25, 8:47 am)
Re: sparc64 / bbc_i2c.c, J.J.Green, (Sun Feb 25, 7:58 pm)
Re: sparc64 / bbc_i2c.c, David Miller, (Mon Feb 26, 2:12 pm)
Re: sparc64 / bbc_i2c.c, Joerg Friedrich, (Tue Feb 27, 1:22 am)
Re: sparc64 / bbc_i2c.c, David Miller, (Tue Feb 27, 1:29 am)
Re: sparc64 / bbc_i2c.c, Emanuele Rocca, (Sun Feb 25, 9:33 am)