Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Rafael J. Wysocki <rjw@...>
Cc: Oleg Nesterov <oleg@...>, Srivatsa Vaddagiri <vatsa@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>, Pavel Machek <pavel@...>, Paul E. McKenney <paulmck@...>, Gautham R Shenoy <ego@...>
Date: Tuesday, February 27, 2007 - 12:33 am

>   * Only the _current_ task can read/write to tsk->flags, but other


This means that we are not going to wait for the kernel thread
(Parent) to freeze. I guess what vatsa suggested in previous mail is
better.

freeezer_do_not_count(void)
{
   if (current->mm) {

       current->flags |= PF_FREEZER_SKIP;
   }

}


freezer_count(void)
{
 if (current->mm) {
current->flags &= ~PF_FREEZER_SKIP;
try_to_freeze();
   }

}


Now if do_fork is called from kernel_thread with CLONE_VFORK we make
the freezer wait till that kernel thread is also frozen. I think this
is important.  with khelper thread it is okey because it is a single
threaded workqueue.

If do_fork is called via a user process we can skip the Parent if the
child got frozen before calling execve.

-aneesh
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 0/3] More freezer patches, Rafael J. Wysocki, (Mon Feb 26, 6:39 am)
[RFC][PATCH 2/3] Freezer: Take kernel_execve into considerat..., Rafael J. Wysocki, (Mon Feb 26, 6:49 am)
[RFC][PATCH 3/3] Freezer: Prevent ___call_usermodehelper fro..., Rafael J. Wysocki, (Mon Feb 26, 6:52 am)
Re: [RFC][PATCH 3/3] Freezer: Prevent ___call_usermodehelper..., Rafael J. Wysocki, (Mon Feb 26, 2:30 pm)
[RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Mon Feb 26, 6:47 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Mon Feb 26, 8:00 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Srivatsa Vaddagiri, (Mon Feb 26, 11:14 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Mon Feb 26, 12:11 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Mon Feb 26, 2:28 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Mon Feb 26, 5:25 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Mon Feb 26, 8:31 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Aneesh Kumar, (Tue Feb 27, 12:33 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Tue Feb 27, 4:37 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Tue Feb 27, 5:21 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Tue Feb 27, 5:53 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Srivatsa Vaddagiri, (Tue Feb 27, 9:23 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Wed Feb 28, 6:57 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Srivatsa Vaddagiri, (Wed Feb 28, 7:01 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Wed Feb 28, 7:00 am)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Wed Feb 28, 3:36 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Oleg Nesterov, (Wed Feb 28, 4:30 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Rafael J. Wysocki, (Wed Feb 28, 6:34 pm)
Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem, Srivatsa Vaddagiri, (Tue Feb 27, 12:42 am)