Re: circular locking: /proc/sys/vm/drop_caches

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Friday, February 23, 2007 - 3:07 am

> On Fri, 23 Feb 2007 07:35:38 +0100 Ingo Molnar <mingo@elte.hu> wrote:

It is - we're taking inode_lock at just the wrong level there and I don't
know how to fix it.  The basic problem is that we're doing a list_head
walk: if we drop the lock we have to start again.

Well, I do know how to fix it: rip the various inode lists and use a tagged
radix tree instead - make writeback's per-superblock inode walk work the
same as writeback's per-inode page walk.  That will also alow us to drop
the lock and then resume the drop_caches thing at the point where we left
off.

But it's a large change and has some quite tricky issues which need to be
carried over from the existing code and I don't have time to do it.

The only (lame) thing I can say for now is that drop_caches is a
debug-only, root-only thing :(

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
circular locking: /proc/sys/vm/drop_caches, Ingo Molnar, (Thu Feb 22, 11:35 pm)
Re: circular locking: /proc/sys/vm/drop_caches, Frederik Deweerdt, (Fri Feb 23, 2:40 am)
Re: circular locking: /proc/sys/vm/drop_caches, Andrew Morton, (Fri Feb 23, 3:07 am)
Re: circular locking: /proc/sys/vm/drop_caches, Ingo Molnar, (Fri Feb 23, 4:36 am)