Home » Mailing list archives » linux-kernel » 2007 » February » 21

[patch 0/6] fault vs truncate/invalidate race fix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin <npiggin@...>
To: Linux Memory Management <linux-mm@...>, Andrew Morton <akpm@...>
Cc: Linux Kernel <linux-kernel@...>, Nick Piggin <npiggin@...>, Benjamin Herrenschmidt <benh@...>
Subject: [patch 0/6] fault vs truncate/invalidate race fix
Date: Wednesday, February 21, 2007 - 12:49 am

The following set of patches are based on current git.

These fix the fault vs invalidate and fault vs truncate_range race for
filemap_nopage mappings, plus those and fault vs truncate race for nonlinear
mappings.

These patches fix silent data corruption that we've had several people hitting
in SUSE kernels. Our kernels have similar patches to lock the page over page
fault, and no problem.

I've also got rid of the horrible populate API, and integrated nonlinear pages
properly with the page fault path.

Downside is that this adds one more vector through which the buffered write
deadlock can occur. However this is just a very tiny one (pte being unmapped
for reclaim), compared to all the other ways that deadlock can occur (unmap,
reclaim, truncate, invalidate). I doubt it will be noticable. At any rate, it
is better than data corruption.

I hope these can get merged (at least into -mm) soon.

Thanks,
Nick

--
SuSE Labs

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 0/6] fault vs truncate/invalidate race fix, Nick Piggin, (Wed Feb 21, 12:49 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Tue Feb 27, 12:36 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Andrew Morton, (Tue Feb 27, 1:32 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Nick Piggin, (Tue Feb 27, 4:50 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Tue Feb 27, 2:26 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Benjamin Herrenschmidt, (Tue Feb 27, 2:54 am)
Re: [patch 0/6] fault vs truncate/invalidate race fix, Dave Airlie, (Sun Mar 18, 7:13 pm)
[patch 4/6] mm: merge populate and nopage into fault (fixes ..., Nick Piggin, (Wed Feb 21, 12:50 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 2:51 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Benjamin Herrenschmidt, (Wed Mar 7, 6:05 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:17 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Benjamin Herrenschmidt, (Wed Mar 7, 6:46 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 3:19 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 3:08 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 4:19 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 4:27 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 4:59 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 5:22 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:52 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:32 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 5:35 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:50 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:11 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 4:38 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 4:47 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 4:51 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 5:07 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 5:32 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:45 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:04 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 6:06 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 6:13 am)
[rfc][patch 7/6] mm: merge page_mkwrite, Nick Piggin, (Wed Mar 7, 6:30 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:21 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 6:24 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:38 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 6:47 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 7:00 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 8:22 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 8:36 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 7:48 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 8:17 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 8:41 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 9:08 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 9:19 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 9:36 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 9:53 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 10:50 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 9:52 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Jeff Dike, (Wed Mar 7, 11:10 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Peter Zijlstra, (Wed Mar 7, 10:34 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 11:01 am)
[RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 12:58 pm)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 7:21 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Nick Piggin, (Thu Mar 8, 7:58 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 8:09 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Thu Mar 8, 7:37 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 7:48 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Thu Mar 8, 8:11 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Nick Piggin, (Thu Mar 8, 8:19 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Miklos Szeredi, (Thu Mar 8, 8:25 am)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Linus Torvalds, (Wed Mar 7, 2:00 pm)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 2:12 pm)
Re: [RFC][PATCH] mm: fix page_mkclean() vs non-linear vmas, Peter Zijlstra, (Wed Mar 7, 2:24 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 9:56 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 5:25 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:18 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 5:26 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:38 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Miklos Szeredi, (Wed Mar 7, 5:28 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 4:35 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:29 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Andrew Morton, (Wed Mar 7, 5:39 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 6:09 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Ingo Molnar, (Wed Mar 7, 4:53 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:28 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Wed Mar 7, 5:44 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Thu Mar 8, 8:39 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 5:49 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Wed Mar 7, 6:02 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Mon Mar 12, 7:01 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Mon Mar 12, 9:19 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Sat Mar 17, 8:17 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Sat Mar 17, 10:50 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Mon Mar 19, 4:44 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Nick Piggin, (Tue Mar 20, 2:00 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Blaisorblade, (Wed Mar 21, 3:45 pm)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Bill Irwin, (Mon Mar 19, 8:04 am)
Re: [patch 4/6] mm: merge populate and nopage into fault (fi..., Jeff Dike, (Sun Mar 18, 9:09 am)
[patch 6/6] mm: remove legacy cruft, Nick Piggin, (Wed Feb 21, 12:50 am)
[patch 5/6] mm: merge nopfn into fault, Nick Piggin, (Wed Feb 21, 12:50 am)
Re: [patch 5/6] mm: merge nopfn into fault, Nick Piggin, (Wed Feb 21, 1:13 am)
[patch 3/6] mm: fix fault vs invalidate race for linear mapp..., Nick Piggin, (Wed Feb 21, 12:50 am)
Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Andrew Morton, (Wed Mar 7, 2:36 am)
Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Nick Piggin, (Wed Mar 7, 2:57 am)
Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Andrew Morton, (Wed Mar 7, 3:08 am)
Re: [patch 3/6] mm: fix fault vs invalidate race for linear ..., Nick Piggin, (Wed Mar 7, 3:25 am)
[patch 2/6] mm: simplify filemap_nopage, Nick Piggin, (Wed Feb 21, 12:49 am)
[patch 1/6] mm: debug check for the fault vs invalidate race, Nick Piggin, (Wed Feb 21, 12:49 am)