Re: [PATCH] mm: remove global locks from mm/highmem.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Matt Mackall <mpm@...>

Cc: Christoph Hellwig <hch@...>, David Chinner <dgc@...>, Andrew Morton <akpm@...>, Martin J. Bligh <mbligh@...>, Peter Zijlstra <a.p.zijlstra@...>, <linux-kernel@...>, <linux-mm@...>, Ingo Molnar <mingo@...>

Subject: Re: [PATCH] mm: remove global locks from mm/highmem.c

Date: Friday, February 2, 2007 - 7:16 pm

On Fri, Feb 02, 2007 at 01:24:40PM -0600, Matt Mackall wrote:
quoted text> On Fri, Feb 02, 2007 at 12:05:11PM +0000, Christoph Hellwig wrote:
> > On Wed, Jan 31, 2007 at 02:22:24PM +1100, David Chinner wrote:
> > > > Yup.  Even better, use clear_highpage().
> > > 
> > > For even more goodness, clearmem_highpage_flush() does exactly
> > > the right thing for partial page zeroing ;)
> > 
> > Note that there are tons of places in buffer.c that could use
> > clearmem_highpage_flush().  See the so far untested patch below:
> > 
> 
> You probably need s/memclear/clearmem/g..

Not needed - as usual, the code is right and the comments
are wrong. ;)

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] mm: remove global locks from mm/highmem.c, Peter Zijlstra, (Sun Jan 28, 10:11 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Andrew Morton, (Sun Jan 28, 6:29 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Ingo Molnar, (Mon Jan 29, 3:08 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Nick Piggin, (Mon Jan 29, 10:02 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Ingo Molnar, (Mon Jan 29, 4:06 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Hugh Dickins, (Mon Jan 29, 3:19 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Ingo Molnar, (Mon Jan 29, 3:53 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Peter Zijlstra, (Mon Jan 29, 5:44 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Martin J. Bligh, (Mon Jan 29, 9:31 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Andrew Morton, (Mon Jan 29, 9:41 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Martin J. Bligh, (Mon Jan 29, 9:49 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Andrew Morton, (Mon Jan 29, 10:15 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, David Chinner, (Tue Jan 30, 8:44 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Andrew Morton, (Tue Jan 30, 9:11 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, David Chinner, (Tue Jan 30, 11:22 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Christoph Hellwig, (Fri Feb 2, 8:05 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, David Chinner, (Fri Feb 2, 7:14 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Matt Mackall, (Fri Feb 2, 3:24 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, David Chinner, (Fri Feb 2, 7:16 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Nick Piggin, (Sun Jan 28, 10:52 pm)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Christoph Hellwig, (Sun Jan 28, 10:49 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Ingo Molnar, (Sun Jan 28, 11:17 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Christoph Hellwig, (Sun Jan 28, 11:28 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Ingo Molnar, (Sun Jan 28, 11:48 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Christoph Hellwig, (Sun Jan 28, 11:54 am)

Re: [PATCH] mm: remove global locks from mm/highmem.c, Ingo Molnar, (Sun Jan 28, 2:19 pm)


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Gabriel C	Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
git:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
David Miller	[GIT]: Networking
Thomas Jarosch	Re: TCP connection stalls under 2.6.24.7
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Re: [PATCH] mm: remove global locks from mm/highmem.c

Online users