On Thu, Feb 01, 2007 at 08:18:57PM +0100, Jens Axboe wrote:
quoted text
> That down() probably wants a replug to precede it. Probably something
> like:
> 
>         if (atomic_read(&bp->b_io_remaining))
>                 blk_replug_current_nested();
> 
> for xfs_buf_wait_unpin() and xfs_buf_lock(). Does this fix it?

Jens, this patch looks like you originally removed the explicit
unplug calls that XFS used to prevent metadata I/O hangs and now you
are putting them back.  Correct?

Reading on from Andrew's earlier comments, shouldn't XFS have
worked unchanged? I'm just trying to understand why you removed
the explicit unplugs in the first place.....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/