Re: [patch] linux/io.h: forward declare struct pci_dev

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Tejun Heo
Date: Saturday, February 10, 2007 - 11:26 pm

Christoph Hellwig wrote:

pci_iomap() depends on two things - PCI and iomap.  AFAIK, there is no 
config to test whether the current arch supports iomap or not. 
Previously it worked because those archs which don't support either one 
doesn't have set CONFIG_GENERIC_IOMAP while not implementing 
arch-specific ones && not compiling any driver which uses the iomap 
interface.  This is why pci_iomap() ended up in lib/iomap.c in the first 
place; otherwise, it cannot be conditionalized correctly as devers 
currently shows (the 'not implementing arch-specific ones' part cannot 
be easily tested).

So, it seems what we need is either 1. bogus iomap implementation for 
all archs or 2. CONFIG_IOMAP.  Hmmm... I think CONFIG_IOMAP is better as 
it will allow leaving out related devres parts (or any generic function 
using iomap).

-- 
tejun
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] linux/io.h: forward declare struct pci_dev, Heiko Carstens, (Sat Feb 10, 4:45 am)
Re: [patch] linux/io.h: forward declare struct pci_dev, Christoph Hellwig, (Sat Feb 10, 8:49 pm)
Re: [patch] linux/io.h: forward declare struct pci_dev, Tejun Heo, (Sat Feb 10, 11:26 pm)
Re: [patch] linux/io.h: forward declare struct pci_dev, Randy Dunlap, (Sat Feb 10, 11:55 pm)
Re: [patch] linux/io.h: forward declare struct pci_dev, Christoph Hellwig, (Sun Feb 11, 12:10 am)
Re: [patch] linux/io.h: forward declare struct pci_dev, Jeff Garzik, (Sun Feb 11, 8:09 am)
Re: [patch] linux/io.h: forward declare struct pci_dev, Heiko Carstens, (Sun Feb 11, 8:31 am)
[PATCH] sort the devres mess out, Al Viro, (Sun Feb 11, 8:41 am)
Re: [PATCH] sort the devres mess out, Jeff Garzik, (Sun Feb 11, 8:49 am)
Re: [PATCH] sort the devres mess out, Roland Dreier, (Sun Feb 11, 3:16 pm)
[PATCH] ia64: Fix noncoherent DMA API so devres builds, Roland Dreier, (Sun Feb 11, 10:30 pm)