On 31 Jan 2007 11:08:14 +0100, Andi Kleen <ak@suse.de> wrote:
floppy.c is not really that ugly or complicated...
It just needs some care:
* cleanup of the over-usage of macros (DP macro etc)
* DocBook documentation would be nice
* make debugging printks optional by using macros in a smart way
(see libata code for examples)
* tracking and fixing current regressions
Once the above is done there would be more room
for the future cleanups and improvements like:
* using bios directly in copy_buffer()
(or avoiding copy completely if possible - need somebody to look at code)
* map user pages instead of memcpy-ing them in fd_copy{in,out}()
* unifying/merging arch specific code into floppy.c (not sure of this one)
* smarter way to handle IRQs
floppy.c rewrite offers an unique chance to learn by practice
from doing simple tasks (macros cleanup) to more advances ones
(involving block layer mechanisms) up to really difficult ones
(IRQ/"actual work" handling methods).
I could help with reviewing patches in case anybody is interested
and have patience to deal with few days delays for reply. However
please don't add me to MAINTAINERS as floppy diver maintainer.
:)
* this is unlikely that we need to add support for new hardware
* by doing the rewrite from scratch we will lose changes history
and possibility to easily track regressions
* for a long time we would have to deal with both drivers
This is just not worth it IMHO.
Bart
-
