Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2.6.24-rc4-git5: Reported regressions from 2.6.23]

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Matt Mackall
Date: Saturday, December 8, 2007 - 11:33 am

On Sat, Dec 08, 2007 at 09:54:06AM -0800, Linus Torvalds wrote:

But what about:

(c) stop passing GFP_ZERO to kmalloc allocators
    stop fiddling with flags inside allocators
    remove ugly if (unlikely(gfp & GFP_ZERO)) from kmalloc allocators
    make kzalloc and kcalloc non-inline functions that do the memset

That should:

- make both kmalloc and kzalloc/kcalloc faster (one less branch)
- reduce kernel size

GFP_ZERO is a bit of an abuse here, given that we don't even intend to
pass it to the underlying "GFP".

-- 
Mathematics is the supreme nostalgia of our time.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Fri Dec 7, 7:40 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Fabio Comolli, (Fri Dec 7, 11:53 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 2:23 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 2:29 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 2:36 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 2:46 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 2:52 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sat Dec 8, 3:12 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 3:20 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Matthew Garrett, (Sat Dec 8, 3:28 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Richard Purdie, (Sat Dec 8, 3:44 am)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, ..., Matt Mackall, (Sat Dec 8, 11:33 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Theodore Tso, (Sat Dec 8, 12:40 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Sat Dec 8, 12:55 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 3:11 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 3:17 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 3:30 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 3:32 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Theodore Tso, (Sat Dec 8, 7:15 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sun Dec 9, 4:54 am)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, ..., Rafael J. Wysocki, (Sun Dec 9, 7:17 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sun Dec 9, 7:20 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sun Dec 9, 7:24 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 11:36 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 11:41 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sun Dec 9, 12:59 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 6:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 1:21 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 1:41 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 1:42 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 1:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Mon Dec 10, 1:59 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 3:45 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:04 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Stefano Brivio, (Mon Dec 10, 4:34 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 4:53 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 5:01 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Arjan van de Ven, (Mon Dec 10, 6:06 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 1:48 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 2:01 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Stefano Brivio, (Tue Dec 11, 2:10 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, ..., Christoph Lameter, (Thu Dec 13, 3:03 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, ..., Christoph Lameter, (Thu Dec 13, 3:07 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Takashi Iwai, (Thu Dec 20, 8:42 am)