Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2.6.24-rc4-git5: Reported regressions from 2.6.23]

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Rafael J. Wysocki <rjw@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>
Date: Saturday, December 8, 2007 - 12:37 pm

On Sat, Dec 08, 2007 at 10:30:39AM +0100, Ingo Molnar wrote:

I was hoping for some discussion about whether it was the best fix.
The current kzalloc thing strikes me as a step backwards for all
allocators. We'd do better to have a single non-inline kzalloc
function rather than an extra branch in the normal kmalloc fast path.

But here's the patch again, with my sign-off:


Avoid calling page allocator with __GFP_ZERO, as we might be in atomic
context and this will make thing unhappy on highmem systems. Instead,
manually zero allocations from the page allocator.

Signed-off-by: Matt Mackall <mpm@selenic.com>

diff -r f7edf7226317 mm/slob.c
--- a/mm/slob.c	Wed Dec 05 15:57:06 2007 -0600
+++ b/mm/slob.c	Wed Dec 05 15:57:51 2007 -0600
@@ -223,6 +231,7 @@ static void *slob_new_page(gfp_t gfp, in
 {
 	void *page;
 
+	gfp &= ~__GFP_ZERO;
 #ifdef CONFIG_NUMA
 	if (node != -1)
 		page = alloc_pages_node(node, gfp, order);
@@ -457,6 +470,8 @@ void *__kmalloc_node(size_t size, gfp_t 
 			page = virt_to_page(ret);
 			page->private = size;
 		}
+		if (unlikely((gfp & __GFP_ZERO) && ret))
+			memset(ret, 0, size);
 		return ret;
 	}
 }


-- 
Mathematics is the supreme nostalgia of our time.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Fri Dec 7, 10:40 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:42 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Mon Dec 10, 4:59 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 6:45 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 7:04 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Stefano Brivio, (Mon Dec 10, 7:34 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 5:01 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Stefano Brivio, (Tue Dec 11, 5:10 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 7:53 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 4:48 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Arjan van de Ven, (Mon Dec 10, 7:56 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 8:01 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Arjan van de Ven, (Mon Dec 10, 9:06 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 4:43 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 4:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sun Dec 9, 7:54 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sun Dec 9, 10:24 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Fabio Comolli, (Sat Dec 8, 2:53 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:23 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:11 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Matt Mackall, (Sat Dec 8, 12:37 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Christoph Lameter, (Thu Dec 13, 6:03 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Rafael J. Wysocki, (Sun Dec 9, 10:17 am)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Christoph Lameter, (Fri Dec 14, 12:07 am)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Christoph Lameter, (Thu Dec 13, 6:07 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:52 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 2:41 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 9:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:21 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:41 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Mon Dec 10, 11:38 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 2:36 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:46 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:42 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Roland Dreier, (Sat Dec 8, 2:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Theodore Tso, (Sat Dec 8, 3:40 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:30 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Theodore Tso, (Sat Dec 8, 10:15 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Takashi Iwai, (Thu Dec 13, 6:49 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Takashi Iwai, (Thu Dec 20, 11:42 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:36 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sun Dec 9, 10:20 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sat Dec 8, 6:12 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 6:20 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sat Dec 8, 6:55 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sun Dec 9, 3:59 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Matthew Garrett, (Sat Dec 8, 6:28 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:29 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:17 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Richard Purdie, (Sat Dec 8, 6:44 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:32 pm)