Re: Major regression on hackbench with SLUB

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Steven Rostedt <rostedt@...>
Cc: LKML <linux-kernel@...>, Christoph Lameter <clameter@...>, Ingo Molnar <mingo@...>, Peter Zijlstra <a.p.zijlstra@...>, Christoph Hellwig <hch@...>
Date: Friday, December 7, 2007 - 2:36 pm

On Fri, 7 Dec 2007, Linus Torvalds wrote:

So I checked hackbench on my machine with oprofile, and while I'm not 
seeing anything that says "ten times slower", I do see it hitting the slow 
path all the time, and __slab_alloc() is 15% of the profile.

With __slab_free() being another 8-9%.

I assume that with many CPU's, those get horrendously worse, with cache 
trashing.

The biggest cost of __slab_alloc() in my profile is the "slab_lock()", but 
that may not be the one that causes problems in a 64-cpu setup, so it 
would be good to have that verified.

Anyway, it's unclear whether the reason it goes into the slow-path because 
the freelist is just always empty, or whether it hits the

	... || !node_match(c, node)

case which can trigger on NUMA. That's another potential explanation of 
why you'd see such a *huge* slowdown (ie if the whole node-match thing 
doesn't work out, slub just never gets the fast-case at all). That said, 
the number of places that actually pass a specific node to slub is very 
limited, so I suspect it's not the node matching. But just disabling that 
test in slab_alloc() might be one thing to test.

[ The whole node match thing is likely totally bogus. I suspect we pay 
  *more* in trying to match nodes than we'd ever likely pay in just 
  returning the wrong node for an allocation, but that's neither here nor 
  there ]

But yeah, I'm not entirely sure SLUB is working out.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Major regression on hackbench with SLUB, Steven Rostedt, (Fri Dec 7, 1:50 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Thu Dec 13, 6:22 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 14, 12:24 am)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:22 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:37 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Fri Dec 21, 6:52 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Fri Dec 21, 6:51 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 7:54 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 12:18 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Fri Dec 21, 12:44 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:11 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Fri Dec 21, 6:49 pm)
Re: Major regression on hackbench with SLUB (more numbers), Peter Zijlstra, (Fri Dec 21, 6:16 pm)
Re: Major regression on hackbench with SLUB (more numbers), Peter Zijlstra, (Fri Dec 21, 6:17 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:27 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Sat Dec 22, 2:01 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Sat Dec 22, 5:00 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Sat Dec 22, 8:59 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Mon Dec 24, 3:21 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Wed Dec 26, 5:31 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Fri Dec 28, 10:52 am)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Thu Dec 27, 1:51 am)
SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 4:28 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 6:59 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 7:22 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 7:54 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 7:53 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 7:58 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 8:02 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 8:45 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 10:19 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 11:26 pm)
Re: SLUB sysfs support, Christoph Lameter, (Wed Jan 2, 4:25 pm)
[patch] slub: provide /proc/slabinfo, Ingo Molnar, (Tue Jan 1, 12:23 pm)
Re: [patch] slub: provide /proc/slabinfo, Arjan van de Ven, (Fri Jan 4, 8:27 pm)
Re: [patch] slub: provide /proc/slabinfo, Linus Torvalds, (Fri Jan 4, 8:49 pm)
Re: Major regression on hackbench with SLUB (more numbers), Jason L Tibbitts III, (Sat Dec 22, 6:52 pm)
Re: Major regression on hackbench with SLUB (more numbers), Alessandro Suardi, (Sun Dec 23, 11:59 pm)
Re: Major regression on hackbench with SLUB (more numbers), Alexey Dobriyan, (Sat Dec 22, 9:01 am)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 7:51 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Mon Dec 24, 3:24 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 12:26 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 5:56 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Fri Dec 14, 2:15 am)
Re: Major regression on hackbench with SLUB, Linus Torvalds, (Fri Dec 7, 1:59 pm)
Re: Major regression on hackbench with SLUB, Linus Torvalds, (Fri Dec 7, 2:36 pm)
Re: Major regression on hackbench with SLUB, Christoph Lameter, (Thu Dec 13, 6:11 pm)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Sat Dec 8, 8:28 pm)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Sat Dec 8, 6:16 pm)
Re: Major regression on hackbench with SLUB, Björn, (Mon Dec 10, 3:38 am)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Mon Dec 10, 10:00 am)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Fri Dec 7, 2:58 pm)
Re: Major regression on hackbench with SLUB, Ingo Molnar, (Fri Dec 7, 1:55 pm)